Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#9971 - rework Superdom plugin

Attached to Project: Rockbox
Opened by Teruaki Kawashima (teru) - Sunday, 01 March 2009, 08:34 GMT+2
Last edited by Andrew Mahone (Unhelpful) - Saturday, 16 May 2009, 10:22 GMT+2
Task Type Patches
Category Plugins
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Version 3.1
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

1. make duplicated code into function such as
putting resources on borad,
moving unit,
attacking to opponent's territory and calculating result.
2. change function computer_war to avoid endless loop.
3. simplify redundancy conditionals.
4. handle canceling at selecting place or input number.
5. use while(1) loop instead of goto.
6. use system font when drawing score. (part of  FS#7593  ?)
this maybe fixes bugs reported at  FS#9962 ,  FS#9963 ,  FS#9965 .
   superdom.patch (80.7 KiB) 
 apps/plugins/superdom.c | 1582 +++++++++++++++++++++---------------------------
 1 file changed, 707 insertions(+), 875 deletions(-)

This task depends upon

Closed by  Andrew Mahone (Unhelpful)
Saturday, 16 May 2009, 10:22 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Committed as r20959.
Comment by Teruaki Kawashima (teru) - Wednesday, 04 March 2009, 16:46 GMT+2
i found some mistakes on my patch..
here is new one.
   superdom.patch (81 KiB) 
 apps/plugins/superdom.c | 1594 +++++++++++++++++++++---------------------------
 1 file changed, 709 insertions(+), 885 deletions(-)

Comment by Teruaki Kawashima (teru) - Tuesday, 14 April 2009, 09:45 GMT+2
update patch.
fix bug. do rb->close(fd); after loading saved game.
resume from proper menu after load the save data. version is changed and cannot use old data.
e.g. if game was saved in War menu, game starts from War menu when loaded the game.
   superdom.20090414.patch (82.7 KiB) 
 apps/plugins/superdom.c | 1625 +++++++++++++++++++++---------------------------
 1 file changed, 736 insertions(+), 889 deletions(-)

Comment by Hilton Shumway (HIllshum) - Monday, 11 May 2009, 18:19 GMT+2
This does fix at least  FS#9962 .
Comment by Hilton Shumway (HIllshum) - Monday, 11 May 2009, 18:39 GMT+2
And  FS#9963 
Comment by Hilton Shumway (HIllshum) - Wednesday, 13 May 2009, 17:26 GMT+2
 FS#9965  is fixed by this too.

Are we going to assume Teruaki is a real name or try to get a better one?
Comment by Teruaki Kawashima (teru) - Saturday, 16 May 2009, 09:24 GMT+2
edited name being shown to a better one.
but I believe my name is already in docs/CREDITS.

Loading...