Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#9988 - fix text editor plugin

Attached to Project: Rockbox
Opened by Teruaki Kawashima (teru) - Friday, 06 March 2009, 11:26 GMT+2
Last edited by Alexander Levin (fml2) - Friday, 20 March 2009, 20:04 GMT+2
Task Type Patches
Category Plugins
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Version 3.1
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

fix bug that causes buffer overflow when the file size is bigger than 128KiB (half of MAX_CHARS).
change concat to not add empty line at the end of file.
change a return value of menu to not make variable "changed" true after returning from Playback Control menu.
to confirm, open a file with text_editor, go straight to playback menu, close the menu and exit plugin.
you will be asked to save or ignore changes despite nothing is changed.
fix bug that Color setting will be lost after edit Extension when editing .colours file.

i tested on gigabeat X30 and it seems OK..
please check.
   text_editor.patch (5.1 KiB) 
 apps/plugins/text_editor.c |   50 ++++++++++++++++++++++++++-------------------
 1 file changed, 29 insertions(+), 21 deletions(-)

This task depends upon

Closed by  Alexander Levin (fml2)
Friday, 20 March 2009, 20:04 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Committed in r20405. Thanks!

Loading...