Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#9990 - Text viewer plugin: The patch that can set global settings.

Attached to Project: Rockbox
Opened by Yoshihisa Uchida (Uchida) - Friday, 06 March 2009, 13:50 GMT+2
Last edited by Yoshihisa Uchida (Uchida) - Wednesday, 17 March 2010, 13:24 GMT+2
Task Type Patches
Category Plugins
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

The patch file to be able to set global settings in the text viewer plugin.

Main menu -> Plugins -> Viewers: select "viewer"

When "Global Settings" is selected from the menu, the setting screen is displayed.

The global settings are saved in ".rocks/viewers/viewer.dat" file.

It is necessary to apply the following patches beforehand to apply this patch.

Text viewer plugins:  FS#9855 ,  FS#9892 ,  FS#9893 ,  FS#9898 ,  FS#9902 ,  FS#9853 ,  FS#9546 ,  FS#8445 ,  FS#9387 .

Show viewer category plugins:  FS#9899 
   viewer_global_settings.patch (4.7 KiB) 
 b/apps/plugins/viewer.c |  112 +++++++++++++++++++++++++++++++++++++++++++++---
 1 file changed, 106 insertions(+), 6 deletions(-)

This task depends upon

Closed by  Yoshihisa Uchida (Uchida)
Wednesday, 17 March 2010, 13:24 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  patch commits and manual updates.
Comment by Yoshihisa Uchida (Uchida) - Friday, 06 March 2009, 14:16 GMT+2
Sorry  FS#9899  ->  FS#9989 .
Comment by Yoshihisa Uchida (Uchida) - Saturday, 07 March 2009, 06:38 GMT+2
Because  FS#9989  had been closed, the patch updated.

To change the global setting, at first a text file is displayed by using the text viewer.
After, please display options menu, and select "Global Settings".

If it's such a hassle to to change the global setting by using this method, please apply patch files of  FS#9989  and viewer_global_settings.patch.
   viewer_global_settings_2.patch (5.7 KiB) 
 b/apps/plugins/viewer.c |  127 +++++++++++++++++++++++++++++++++++++++++++++---
 1 file changed, 120 insertions(+), 7 deletions(-)

Comment by Gman (Thecoolgman) - Tuesday, 16 June 2009, 12:24 GMT+2
Please, Please, PLEASE! Update these! They finally broke.
Comment by Yoshihisa Uchida (Uchida) - Wednesday, 17 June 2009, 11:19 GMT+2
sync r21316
   viewer_global_settings_3.patch (4.8 KiB) 
 b/apps/plugins/viewer.c |   97 ++++++++++++++++++++++++++++++++++++++++++++----
 1 file changed, 90 insertions(+), 7 deletions(-)

Comment by Gman (Thecoolgman) - Wednesday, 17 June 2009, 12:14 GMT+2
Thank but do you have to update the others? Or dose this include them?
Comment by Gman (Thecoolgman) - Wednesday, 17 June 2009, 12:19 GMT+2
Never mind. Thank You.
Comment by Gman (Thecoolgman) - Tuesday, 18 August 2009, 07:06 GMT+2
I do believe this needs a resync my good man.
Comment by Yoshihisa Uchida (Uchida) - Saturday, 06 February 2010, 10:15 GMT+2
I am not good at anything by the current illness. Because I had recovered from the illness at last, I can restart this correction.
Please wait for a new patch for a while.
Comment by Yoshihisa Uchida (Uchida) - Saturday, 20 February 2010, 06:52 GMT+2
sync r24782
   viewer_global_settings_4.patch (4.8 KiB) 
 b/apps/plugins/viewer.c |   97 ++++++++++++++++++++++++++++++++++++++++++++----
 1 file changed, 90 insertions(+), 7 deletions(-)

Loading...