Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#9992 - pictureflow input rework

Attached to Project: Rockbox
Opened by Andrew Mahone (Unhelpful) - Sunday, 08 March 2009, 05:51 GMT+2
Last edited by Andrew Mahone (Unhelpful) - Thursday, 09 April 2009, 06:11 GMT+2
Task Type Patches
Category Plugins
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Version 3.1
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This rework of pictureflow input uses the the core CONTEXT_TREE in the track list, and a custom action context in the album list except for scrollwheel targets, which use CONTEXT_TREE for both. Tree context rather than standard is used so the tree context's quit button mapping can be used as a shortcut to exit PF. The standard cancel button will exit if in the album list, or return to album list if viewing a track list. The select button will select an album and change to track list.
   pictureflow_keymaps-200903072350.patch (17.8 KiB) 
 b/apps/plugins/pictureflow.c |  287 +++++++++++++++++++++++++++++++++----------
 1 file changed, 223 insertions(+), 64 deletions(-)

This task depends upon

View Dependency Graph

This task blocks these from closing
 FS#10104 - PictureFlow manual update for new input work. 
Closed by  Andrew Mahone (Unhelpful)
Thursday, 09 April 2009, 06:11 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  committed as r20651
Comment by Andrew Mahone (Unhelpful) - Monday, 09 March 2009, 00:46 GMT+2
Further changes, the base for chaining contexts is CONTEXT_STD. Another context on top of that adds the dedicated quit button, and any other buttons used throughout PF, and a context on top of both of those, used only in the album list, adds left/right scrolling.
   pictureflow_keymaps-200903081944.patch (14 KiB) 
 b/apps/plugins/pictureflow.c |  267 ++++++++++++++++++++++++++++++++-----------
 1 file changed, 203 insertions(+), 64 deletions(-)

Comment by Andrew Mahone (Unhelpful) - Monday, 09 March 2009, 12:05 GMT+2
Remove c200 dedicated quit button, so it can be used for menu.
   pictureflow_keymaps-200903090703.patch (14 KiB) 
 b/apps/plugins/pictureflow.c |  266 ++++++++++++++++++++++++++++++++-----------
 1 file changed, 202 insertions(+), 64 deletions(-)

Comment by Thomas Martitz (kugel.) - Sunday, 15 March 2009, 04:21 GMT+2
Well, I know of the PLA problems, but I'd really try to avoid getting rid of it (since I'm still in love with the general idea of it).
May it's worth looking at bubbles.rock? It has basically the same problems. In the main screen, you use scrollwheel/left right, and in the game menu you use scrollwheel/up down.

I still think PLA has too much contexts. It should be only _1_ context with 6-7 buttons (4 directions, select. quit, optinally context) + 1 exception context for scrollwheel targets.
Comment by Andrew Mahone (Unhelpful) - Sunday, 15 March 2009, 12:57 GMT+2
One keymap for absolutely everything is not going to work in general, and I don't think a "generic" keymap works here. The PLA-based pictureflow uses scrollwheel for up/down as well as left/right, but that is not really the main problem. The track list should work as much like core list views as possible, and that can't happen if the left and right buttons are stolen for scroll actions.
Comment by Marianne Arnold (pixelma) - Monday, 16 March 2009, 18:00 GMT+2
Looking at bubbles.c is not worth at all IMO. Being the first plugin converted to PLA you would expect it to work perfectly - but no, it did not until some ugly exceptions were added. That's showing nicely how PLA does not work in reality, especially if you need slightly non-standard controls.

One context with 6-7 buttons could work for plugins that only need such a generic control scheme, to me pictureflow just is not one of that type (see Unhelpful's post for an example)...
Comment by Andrew Mahone (Unhelpful) - Monday, 23 March 2009, 02:44 GMT+2
I've started going over individual keymaps,trying to make sure they're reasonable in terms of user expectations based on core actions. I've implemented some suggestions from discussions with Marianne about the Ondio - core mappings are preserved as much as possible, long off is the dedicated quit button, up is select in album list, with down disabled in album list to avoid confusion.
   pictureflow_keymaps-200903222135.patch (12.2 KiB) 
 b/apps/plugins/pictureflow.c |  233 ++++++++++++++++++++++++++++++-------------
 1 file changed, 165 insertions(+), 68 deletions(-)

Comment by Andrew Mahone (Unhelpful) - Wednesday, 25 March 2009, 05:20 GMT+2
More keymap updates, again mostly going over the "basic" mapping that adds quit key to the standard context.
   pictureflow_keymaps-200903250018.patch (12.3 KiB) 
 b/apps/plugins/pictureflow.c |  234 ++++++++++++++++++++++++++++++-------------
 1 file changed, 166 insertions(+), 68 deletions(-)

Comment by Andrew Mahone (Unhelpful) - Thursday, 26 March 2009, 06:54 GMT+2
Finished going over supported targets, also fixed some errors/inconsistencies for a few targets done earlier.
   pictureflow_keymaps-200903260153.patch (11.5 KiB) 
 b/apps/plugins/pictureflow.c |  215 +++++++++++++++++++++++++++++--------------
 1 file changed, 147 insertions(+), 68 deletions(-)

Comment by Andrew Mahone (Unhelpful) - Thursday, 02 April 2009, 08:00 GMT+2
Changed many targets that were using long POWER/OFF for quit to short POWER/OFF. The exceptions are targets where this is also the menu button, and ones where it is the *only* cancel button.
   pictureflow_keymaps-200904020158.patch (11.4 KiB) 
 b/apps/plugins/pictureflow.c |  215 +++++++++++++++++++++++++++++--------------
 1 file changed, 147 insertions(+), 68 deletions(-)

Comment by Andrew Mahone (Unhelpful) - Tuesday, 07 April 2009, 04:08 GMT+2
Since the H10's left/right buttons are not part of a directional set, and the up/down are presented as a scroller, don't use custom scroll buttons in H10 album list.
   pictureflow_keymaps-200904062205.patch (11.3 KiB) 
 b/apps/plugins/pictureflow.c |  215 +++++++++++++++++++++++++++++--------------
 1 file changed, 147 insertions(+), 68 deletions(-)

Loading...