Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10016 - v1 tag not read if v2 tag present regardless of content

Attached to Project: Rockbox
Opened by Jonas Häggqvist (rasher) - Thursday, 12 March 2009, 23:33 GMT+2
Last edited by MichaelGiacomelli (saratoga) - Tuesday, 26 July 2011, 21:01 GMT+2
Task Type Bugs
Category ID3 / meta data
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Version 3.1
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Rockbox doesn't read the tags of this file.

It contains the following tags:

ID3v1 tag
Title: Now Get Busy
Artist: Beastie Boys
Album: The Wired CD
Year: 2004
Track: 1
Genre: Hip-Hop
ID3v2.4.0 tag
replaygain_album_gain (TXXX): -7.62 dB
replaygain_album_peak (TXXX): 1.278176665
replaygain_track_peak (TXXX): 1.033416986
replaygain_track_gain (TXXX): -8.38 dB

However, Rockbox only reads the v2 tag, never bothering to check for the artist, title, album etc tag in the v1 tag.

Track is licensed CC-NC-Sampling+ 1.0 and copyright Beastie Boys, obviously.
   01 - Beastie Boys - Now Get Busy.mp3 (1.87 MiB)
This task depends upon

Closed by  MichaelGiacomelli (saratoga)
Tuesday, 26 July 2011, 21:01 GMT+2
Reason for closing:  Not a Bug
Additional comments about closing:  Since it was decided that we didn't want to merge different tags into one metadata entry for a given file, this isn't actually a bug. Its just a file with broken tags.
Comment by Jonathan Gordon (jdgordon) - Wednesday, 16 December 2009, 09:58 GMT+2
I remember the argument but not the outcome... do you remember what was decided?
Comment by Rui Araújo (Akur) - Thursday, 11 February 2010, 02:29 GMT+2
Shouldn't Rockbox fetch the v1 tag if the v2 tag is empty?
Comment by Andree Buschmann (Buschel) - Saturday, 13 March 2010, 10:11 GMT+2
This patch checks whether there has been metadata (artist, title, album) read from the id3v2 tag. If not, it will try to read this information from the id3v1 tag.
   mp3_metadata_v01.patch (1 KiB) 
 apps/metadata/mp3.c |   16 ++++++++++++++--
 1 file changed, 14 insertions(+), 2 deletions(-)

Comment by Andree Buschmann (Buschel) - Sunday, 14 March 2010, 17:30 GMT+2
It is agreed not to support mixed tags in rockbox. Therefor this patch will not be added to svn.
Comment by Frank Gevaerts (fg) - Sunday, 14 March 2010, 23:54 GMT+2
For the record, I think that if all relevant tags are missing in v2, reading v1 is reasonable. The set of relevant tags should then at least include title and artist, but possibly also album and genre.

Loading...