Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10018 - general pp bootloader: load OF if rockbox isn't found

Attached to Project: Rockbox
Opened by Nils Wallménius (nls) - Friday, 13 March 2009, 11:41 GMT+2
Last edited by Nils Wallménius (nls) - Tuesday, 17 March 2009, 21:09 GMT+2
Task Type Patches
Category Bootloader
Status Closed
Assigned To No-one
Player Type PortalPlayer-based
Severity Low
Priority Normal
Reported Version Version 3.1
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch makes the general pp bootloader try to load the OF if it can't load rockbox. On c200 this fixes a bug that caused the bootloader to enter a loop if rockbox wasn't found.

If the bootloader is trying to load rockbox but can't find it it now turns on verbose and sleeps for 5 seconds so that the messages can be read before starting the OF.

tested and working on c240.

this also drops support for loading old .e200 and .h10 files for those players and removed
some #if 0'ed code for dumping the firmware partition.
   c200bootloader_fix.diff (3.4 KiB) 
 firmware/export/config-h10.h     |    1 
 firmware/export/config-e200.h    |    1 
 firmware/export/config-h10_5gb.h |    1 
 bootloader/main-pp.c             |   53 ++++++++++++---------------------------
 4 files changed, 17 insertions(+), 39 deletions(-)

This task depends upon

Closed by  Nils Wallménius (nls)
Tuesday, 17 March 2009, 21:09 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  committed
Comment by Bertrik Sikken (bertrik) - Friday, 13 March 2009, 12:30 GMT+2
Makes a lot of sense to me!
Comment by Nils Wallménius (nls) - Monday, 16 March 2009, 22:36 GMT+2
cosmetic change, don't print as much text if no button is held down
edit: oh and tested and working on e200
   c200bootloader_fix2.diff (3.4 KiB) 
 bootloader/main-pp.c             |   55 +++++++++++++--------------------------
 firmware/export/config-h10.h     |    1 
 firmware/export/config-e200.h    |    1 
 firmware/export/config-h10_5gb.h |    1 
 4 files changed, 19 insertions(+), 39 deletions(-)

Comment by Frank Gevaerts (fg) - Tuesday, 17 March 2009, 20:55 GMT+2
Works fine on my H10 5GB UMS

Loading...