This is the bug/patch tracker for Rockbox. Click here for more information.
Quick links: Bugs · Patches · Rockbox frontpage
FS#10045 - Lyre port patch
Attached to Project:
Rockbox
Opened by jpcasainho (casainho) - Monday, 23 March 2009, 08:28 GMT+2
Last edited by Daniel Stenberg (bagder) - Monday, 30 March 2009, 14:22 GMT+2
Opened by jpcasainho (casainho) - Monday, 23 March 2009, 08:28 GMT+2
Last edited by Daniel Stenberg (bagder) - Monday, 30 March 2009, 14:22 GMT+2
|
DetailsThis patch id for apply on Rockbox sourceSVN version 20485.
This is the first pacth for the Lyre music player and recorder (were named as Rockbox Player). This patch is for the bootloader and just make the kernel_init() working. I tested it using sleep(4*HZ) on JTAG debug. 
lyre_bootloader.patch
(287.3 KiB)
bootloader/SOURCES | 3 bootloader/lyre.c | 36 tools/configure | 25 apps/keymaps/keymap-lyre.c | 334 ++ firmware/export/at91sam9260.h | 2521 ++++++++++++++++++++ firmware/export/config.h | 13 firmware/export/config-lyre.h | 95 firmware/SOURCES | 12 firmware/target/arm/at91sam/app.lds | 107 firmware/target/arm/at91sam/boot.lds | 77 firmware/target/arm/at91sam/lyre/debug-lyre.c | 34 firmware/target/arm/at91sam/lyre/adc-lyre.c | 31 firmware/target/arm/at91sam/lyre/backlight-lyre.c | 45 firmware/target/arm/at91sam/lyre/button-target.h | 48 firmware/target/arm/at91sam/lyre/timer-target.h | 42 firmware/target/arm/at91sam/lyre/lcd-lyre.c | 27 firmware/target/arm/at91sam/lyre/system-target.h | 29 firmware/target/arm/at91sam/lyre/debug-target.h | 26 firmware/target/arm/at91sam/lyre/adc-target.h | 28 firmware/target/arm/at91sam/lyre/backlight-target.h | 26 firmware/target/arm/at91sam/lyre/button-lyre.c | 99 firmware/target/arm/at91sam/lyre/crt0.S | 247 + firmware/target/arm/at91sam/lyre/timer-lyre.c | 122 firmware/target/arm/at91sam/lyre/kernel-lyre.c | 78 firmware/target/arm/at91sam/lyre/lcd-target.h | 24 firmware/target/arm/at91sam/lyre/system-lyre.c | 152 + 26 files changed, 4278 insertions(+), 3 deletions(-) |
This task depends upon
Closed by Daniel Stenberg (bagder)
Monday, 30 March 2009, 14:22 GMT+2
Reason for closing: Accepted
Additional comments about closing: Thanks committed to SVN in rev 20574
Monday, 30 March 2009, 14:22 GMT+2
Reason for closing: Accepted
Additional comments about closing: Thanks committed to SVN in rev 20574
Some cosmetic comments (I mentioned these in IRC as well):
1) "//" shouldn't be used (use /* .... */)
2) No TAB characters.
3) No lines longer than 80 characters
4) Some files have a mixture of DOS and Unix line endings (this shows as ^M characters at the end of some lines in my editor (emacs))
5) For a bootloader patch, no need to include apps/keymaps/keymap-lyre.c
You've created a new target simply called "Lyre". I'm assuming that there will be various different versions of this player - at least a couple of prototypes, and then a "real" device. You may want to call the target that this patch is for something like LYRE_PROTO1 (Prototype 1). If you do that, then you (or other developers) can add further targets for other variations of your device.
In config-lyre.h, you define "BOOTFILE_EXT" to be "rockboxplayerlittle" - this should be changed to "lyre".
Is any code in your patch (e.g. at91sam9260.h) taken from the Atmel SDK? If so, then you should include a header file from that project, including their copyright and license information.
Plus one more cosmetic comment - some of your code is indented with two spaces, not the Rockbox standard four.
The only thing missing is the "at91sam9260.h" because it is big and I need more time to format is style.
Is there anything more that need to be worked?