This is the bug/patch tracker for Rockbox. Click here for more information.
Quick links: Bugs · Patches · Rockbox frontpage
FS#1008 - Edit ID3 Tags
Attached to Project:
Rockbox
Opened by Jeremy Zoss (jzoss) - Tuesday, 04 March 2003, 07:09 GMT+2
Last edited by Henrik Backe (hbacke) - Tuesday, 29 November 2005, 20:33 GMT+2
Opened by Jeremy Zoss (jzoss) - Tuesday, 04 March 2003, 07:09 GMT+2
Last edited by Henrik Backe (hbacke) - Tuesday, 29 November 2005, 20:33 GMT+2
|
Details-----------------------------------
Functions: ----------------------------------- - allows editing of title, artist, album, year, tracknum, genre tags in existing mp3 files - allows setting ID3 tags for recordings - writes both id3v1 and id3v2 tags ---------------------------------------- Limitations: ---------------------------------------- - relatively untested (esp. on player), so make sure you have backups of critical files before editing! - will overwrite any unsupported existing tags (lyrics, comments, etc) - due to write-from-even-offset limitation (and my coding laziness), resizing id3v2 tags may not be byte-perfect for last byte of id3v2 tag (usually just padding) and last byte of mp3 data. - only "remembers" last id3 tag used for recording-tagging. Would be nice to have a short history of prev-5 entries for each tag. - no batch ID3 edit (would be quite slow) ---------------------------------------- Files Modified: ---------------------------------------- - apps/settings.c -- load/save_rec_settings (last ID3 tags), set_genre UI for selecting ID3 genre - apps/settings.h -- set_genre prototype - apps/sound_menu.c -- add "Edit ID3 Tags" entry to recsettings menu - apps/tree.c -- quickMenu entry for "Edit ID3 Tags" get_dirBrowse_currFile so external code can read currently selected filename - apps/tree.h -- get_dirBrowse_currFile prototype - apps/wps-display.c -- moved genre definitions to id3.c - apps/wps-display.h -- removed wps_get_genre - apps/wps.c -- edit_id3_tags UI + wrapper function replaced browse_id3 w/ above UI - apps/wps.h -- edit_id3_tags prototype - apps/lang/english.lang -- add LANG_EDIT_ID3 entry - apps/recorder/recording.c -- interface for external code to edit recording's ID3 tags reserve space for id3v2 tags before recording starts move src to F2 quickmenu, edit ID3 tags on F3 quickmenu - apps/recorder/recording.h -- rec_edit_id3() prototype - firmware/id3.c -- macros to take int -> SYNC (or not) bytes added genre definitions from wps-display write_id3v1_tags, write_id3v2_tags resize_id3v2 to shfft mp3 data to make room for id3v2 header write_id3v1_tags, write_id3v2_tags - firmware/mpeg.c -- moved recording file creation to recording.c write_id3_tags on recording STOP - firmware/export/id3.h -- resize_id3v2, write_id3_tags, id3_get_genre prototypes Whew! Sorry if that was a little wordy. Lemme know, and I'll trim out all those modified-file descriptions. =) 
editID3_030306.patch
(61.3 KiB)
apps/main.c | 4 apps/settings.c | 254 ++++++++++++++++++++++++++ apps/settings.h | 4 apps/sound_menu.c | 4 apps/tree.c | 80 +++++++- apps/tree.h | 2 apps/wps-display.c | 38 --- apps/wps-display.h | 1 apps/wps.c | 449 ++++++++++++++++++++++++++++++++++++---------- apps/wps.h | 2 apps/lang/english.lang | 5 apps/recorder/recording.c | 155 ++++++--------- apps/recorder/recording.h | 9 firmware/id3.c | 352 ++++++++++++++++++++++++++++++++++++ firmware/mpeg.c | 19 + firmware/export/id3.h | 5 16 files changed, 1148 insertions(+), 235 deletions(-)
edit_id3.diff
(58.1 KiB)
dev/apps/filetypes.c | 18 dev/apps/filetypes.h | 1 dev/apps/onplay.c | 12 dev/apps/plugin.c | 8 dev/apps/plugin.h | 12 dev/apps/plugins/edit_id3.c | 1297 ++++++++++++++++++++++++++++++++++++++++ dev/apps/plugins/metronome.c | 2 dev/apps/plugins/viewers.config | 3 dev/apps/screens.c | 139 ---- dev/apps/screens.h | 1 dev/apps/tree.c | 20 dev/apps/tree.h | 1 dev/apps/wps-display.c | 13 dev/apps/wps.c | 10 dev/firmware/export/id3.h | 15 dev/firmware/id3.c | 49 - 16 files changed, 1411 insertions(+), 190 deletions(-)
edit_id3.diff
(59.5 KiB)
dev/apps/filetypes.c | 18 dev/apps/filetypes.h | 1 dev/apps/onplay.c | 12 dev/apps/plugin.c | 10 dev/apps/plugin.h | 14 dev/apps/plugins/SOURCES | 1 dev/apps/plugins/edit_id3.c | 1297 ++++++++++++++++++++++++++++++++++++++++ dev/apps/plugins/metronome.c | 2 dev/apps/plugins/viewers.config | 3 dev/apps/screens.c | 181 ----- dev/apps/screens.h | 1 dev/apps/tree.c | 20 dev/apps/tree.h | 1 dev/apps/wps-display.c | 13 dev/apps/wps.c | 8 dev/apps/wps.h | 4 dev/firmware/export/id3.h | 11 dev/firmware/id3.c | 49 - 18 files changed, 1415 insertions(+), 231 deletions(-)
01_edit_id3.diff
(60.4 KiB)
dev/apps/filetypes.c | 18 dev/apps/filetypes.h | 1 dev/apps/gui/gwps-common.c | 12 dev/apps/gui/gwps.c | 8 dev/apps/gui/gwps.h | 4 dev/apps/metadata.c | 5 dev/apps/onplay.c | 12 dev/apps/plugin.c | 9 dev/apps/plugin.h | 14 dev/apps/plugins/SOURCES | 1 dev/apps/plugins/edit_id3.c | 1298 ++++++++++++++++++++++++++++++++++++++++ dev/apps/plugins/metronome.c | 2 dev/apps/plugins/viewers.config | 1 dev/apps/screens.c | 181 ----- dev/apps/screens.h | 1 dev/apps/tree.c | 21 dev/apps/tree.h | 1 dev/firmware/export/id3.h | 11 dev/firmware/id3.c | 49 - 19 files changed, 1416 insertions(+), 233 deletions(-)
editID3_030816.patch
(61 KiB)
apps/main_menu.c | 38 + apps/onplay.c | 33 + apps/plugin.c | 32 + apps/plugin.h | 22 apps/tree.c | 20 apps/tree.h | 1 apps/wps-display.c | 45 - apps/wps.c | 22 apps/wps.h | 2 firmware/id3.c | 68 +- firmware/export/id3.h | 13 apps/plugins/edit_id3.c | 1281 ++++++++++++++++++++++++++++++++++++++++++++++++ 12 files changed, 1500 insertions(+), 77 deletions(-)
strcspn.c
(1.1 KiB)
edit_id3.patch
(59 KiB)
apps/settings.c | 234 ++++++++++++++++++++++++ apps/settings.h | 1 apps/sound_menu.c | 6 apps/tree.c | 67 ++++++- apps/tree.h | 1 apps/wps-display.c | 38 ---- apps/wps-display.h | 1 apps/wps.c | 435 +++++++++++++++++++++++++++++++++++----------- apps/wps.h | 2 apps/lang/english.lang | 5 apps/recorder/recording.c | 153 ++++++---------- apps/recorder/recording.h | 1 firmware/id3.c | 352 +++++++++++++++++++++++++++++++++++++ firmware/mpeg.c | 17 + firmware/export/id3.h | 5 15 files changed, 1080 insertions(+), 238 deletions(-)
editID3+recFilename_030306.patch
(70.5 KiB)
apps/main.c | 4 apps/settings.c | 279 ++++++++++++++++++++++++++++ apps/settings.h | 4 apps/sound_menu.c | 7 apps/tree.c | 80 +++++++- apps/tree.h | 2 apps/wps-display.c | 38 --- apps/wps-display.h | 1 apps/wps.c | 449 ++++++++++++++++++++++++++++++++++++---------- apps/wps.h | 2 apps/lang/english.lang | 10 + apps/recorder/recording.c | 375 ++++++++++++++++++++++++++++---------- apps/recorder/recording.h | 11 + firmware/id3.c | 352 ++++++++++++++++++++++++++++++++++++ firmware/mpeg.c | 19 + firmware/export/id3.h | 5 16 files changed, 1396 insertions(+), 242 deletions(-)
editid3-updated.patch
(61.8 KiB)
apps/filetypes.c | 18 apps/filetypes.h | 1 apps/onplay.c | 12 apps/plugin.c | 11 apps/plugin.h | 15 apps/screens.c | 143 ---- apps/screens.h | 1 apps/tree.c | 20 apps/tree.h | 1 apps/wps-display.c | 13 apps/wps.c | 7 apps/wps.h | 4 apps/plugins/edit_id3.c | 1298 ++++++++++++++++++++++++++++++++++++++++++++ apps/plugins/metronome.c | 2 apps/plugins/viewers.config | 3 firmware/id3.c | 49 - firmware/export/id3.h | 14 17 files changed, 1418 insertions(+), 194 deletions(-) |
This task depends upon
Closed by Daniel Stenberg (bagder)
Saturday, 19 May 2007, 17:24 GMT+2
Reason for closing: Out of Date
Saturday, 19 May 2007, 17:24 GMT+2
Reason for closing: Out of Date
great patch -- just played around with it a bit, and I love it!
Where did the files go?
I dunno...I didn't delete them. :S And the originals are
at home, so I can't re-upload them
WOW!!! Can't wait to see this in the daily builds! Looks
superb!
sounds excellent !!!
can't wait to see this feature blend in the daily build !
meni.
there are a few things I think could improve it considerably:
--the option to choose between writing ID3v1 and ID3v2 tags
or both. Not remove ID3v1 support but make it an option in
the options menu. Tag editing /ID3v1/ID3v2/ID3v1&2
--do not erase already written tags
--and last but not least... remember already used tags.
like for artists save the last 5 . that way if you record an
entire album onto the recorder, you do not have to type the
same information in again and again.
Seems I can't delete my old patch ... Arrrr.
Anyway, use the new (030306) patch. This patch doesn't
apply cleanly on top of the custom recFilename patch (or
vice-versa), so I uploaded a combined patch too.
Major revision in the works. Cleaned up, preserves
existing unsupported tags, removed recording-ID3-tag
functionality (kinda a screwy idea anyway) and any
dependency on recFilename patch. Allows editing (as
long as no file-resize) while playing. Will be out as
soon as I find a free weekend to tie up loose ends. =)
Will you make this a plugin? I will add kbd_input() to the plugin
api.
Finally, an update:
- it's a plugin now
- now preserves existing unsupported ID3 tags
- editor now can revert and clear tags (use LEFT)
BUT -- there's a memory leak somewhere that causes
squirrelly behavior and is a pita to track down. So, feel
free to try out, but use at your own risk...
could you update this for the latest CVS? It is a great
patch... also would it be possible to show only the tags where
there is an entry for them? (and include more of the ID3v2
tags) :-)
could you update this for the latest CVS? It is a great
patch... also would it be possible to show only the tags where
there is an entry for them? (and include more of the ID3v2
tags) :-)
This looks like an excellent candidate for the new "Open
with..." feature. But it needs updating, a lot has happened
in CVS since the last patch.
Updated version by Henrik Backe, doesn't apply cleanly on
recent versions.
Updated version. It crashes, and possibly doesn't work on
Players. I marked the place of the crash in the plugin sources.
This would close RFE #577871 (man, do I wish sourceforge
could link such requests somehow)
Updated patch, I only use it to browse id3 tags so the edit
part needs more testing. .../Henrik
Added keys for new targets (iriver,ipod) and fixed keys for
ondio. The key assignments are probably not optimal, but at
least it compiles for all targets now.
The patch reduces the binary size with ~490 bytes for
recorder v1 :-)
.../Henrik
FS#5927for an actual attempt. Currently that is ID3v1.1 only.diff
patch
c
files?
where to copy them? how to install?