- Status Closed
- Percent Complete
- Task Type Patches
- Category Plugins
- Assigned To No-one
- Operating System All players
- Severity Low
- Priority Very Low
- Reported Version Version 3.1
- Due in Version Undecided
-
Due Date
Undecided
- Votes
- Private
FS#10087 - Improvements to rocklife: file loading; code readability
The patch does the following:
1. Reading of the file is now done char by char. This makes it not dangerous if the file is big
2. Code readability is improved via introducing of get_cell
3. Slight speed improvement in calculating the next generation (n[4] is taken from the previous generation)
4. A first step is made in decoupling of the grid size from the LCD size
Closed by fml2
2009-04-03 20:26
Reason for closing: Accepted
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407
2009-04-03 20:26
Reason for closing: Accepted
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407
Committed in r20610
Loading...
Available keyboard shortcuts
- Alt + ⇧ Shift + l Login Dialog / Logout
- Alt + ⇧ Shift + a Add new task
- Alt + ⇧ Shift + m My searches
- Alt + ⇧ Shift + t focus taskid search
Tasklist
- o open selected task
- j move cursor down
- k move cursor up
Task Details
- n Next task
- p Previous task
- Alt + ⇧ Shift + e ↵ Enter Edit this task
- Alt + ⇧ Shift + w watch task
- Alt + ⇧ Shift + y Close Task
Task Editing
- Alt + ⇧ Shift + s save task
char is unsigned by default on ARM, so checking buf ⇐ 0 (implicating signed) might be problematic. Shouldn’t it be checking for EOF anyway?
Yes, that sounds right. I am trying to teach myself C on-the-fly, so please make whatever changes seem appropriate and I will learn by example.
@kugel: read returns the number of bytes read, or 0 on EOF, or a negative value on error. The return value is stored in an int and then tested. Where do you see a problem?
Sync to r20608