Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10091 - Boots instead of charging screen ('Car Mode' is 'off')

Attached to Project: Rockbox
Opened by Alun Thomas (tspoon) - Thursday, 02 April 2009, 22:02 GMT+2
Last edited by Boris Gjenero (dreamlayers) - Monday, 06 April 2009, 03:49 GMT+2
Task Type Bugs
Category Battery/Charging
Status Closed
Assigned To No-one
Player Type Archos Recorder
Severity Low
Priority Normal
Reported Version Version 3.2
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

With 3.2 loaded, Rockbox starts automatically when the DC jack is inserted, even though the 'Car Mode' Setting is set to 'off'. It normally would show the charging screen and not boot into rockbox.
This task depends upon

Closed by  Boris Gjenero (dreamlayers)
Monday, 06 April 2009, 03:49 GMT+2
Reason for closing:  Fixed
Additional comments about closing:  Fixed in r20634
Comment by Boris Gjenero (dreamlayers) - Friday, 03 April 2009, 01:25 GMT+2
Are you starting Rockbox from flash? Does charger detection work?
Comment by Alun Thomas (tspoon) - Friday, 03 April 2009, 03:11 GMT+2
Yes I have set the 'P' and 'C' (plugged and charging) flags to show on my wps, and they are functioning correctly. I am starting from flash, with bootloader 3.0, although it also does for bootloader 2.0, but not if I return to an earlier release of rockbox in flash.
Comment by Boris Gjenero (dreamlayers) - Friday, 03 April 2009, 05:58 GMT+2
The return value of charger_inserted() is based on periodic polling of hardware by power_thread(). When init() checks whether to go to the charging screen, power_thread() has not yet checked charger status for the first time, and so charger_inserted() returns false. This patch checks the status of the hardware directly via power_input_status().
   charging_screen_use_power_input_status.patch (0.5 KiB) 
 apps/main.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comment by Alun Thomas (tspoon) - Friday, 03 April 2009, 06:00 GMT+2
Thanks boris, I'm not set up to compile right now, but hopefully your work will result in a quick fix in the daily builds.
Comment by Boris Gjenero (dreamlayers) - Friday, 03 April 2009, 06:12 GMT+2
Here's a build with the patch: http://drop.io/dreamlayers/asset/rockbox-20608m-recorderv1-fs10091-zip

Loading...