Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10093 - Center on loaded file when browsing

Attached to Project: Rockbox
Opened by Jonas Häggqvist (rasher) - Friday, 03 April 2009, 17:42 GMT+2
Last edited by Jonas Häggqvist (rasher) - Monday, 22 June 2009, 20:02 GMT+2
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Version 3.2
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch centers the browser on the currently loaded font when doing "browse fonts".

Something smarter should probably be done that does the same for themes, languages and wps files.
   center_on_selected_FS#10093_v1.diff (0.7 KiB) 
 apps/tree.c |   10 ++++++++++
 1 file changed, 10 insertions(+)

This task depends upon

Closed by  Jonas Häggqvist (rasher)
Monday, 22 June 2009, 20:02 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Committed in r21464
Comment by Jonas Häggqvist (rasher) - Tuesday, 16 June 2009, 11:56 GMT+2
Updated patch that also works for languages, except when no language is selected, in which case it should use English, but doesn't currently.
   center_on_selected_FS#10093_v2.diff (1.2 KiB) 
 apps/tree.c |   22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

Comment by Jonas Häggqvist (rasher) - Monday, 22 June 2009, 17:47 GMT+2
Fixes:
- Now picks English when no language has been set.
- Accidentally set the "current" variable static, which meant it was set even when none of the conditions were true (eg. when browsing themes)
Additions:
- Works for FM presets
- Works for WPS
- Works for RWPS
Remaining bugs:
- set_current_file() does something to the dirbrowser which means you don't exit it when you press back, so when you browse fonts, and press back, you're in .rockbox, and back again brings you to the root. Only on the third press on back are you taken to the menu.
   center_on_selected_FS#10093_v3.diff (2.2 KiB) 
 apps/tree.c |   52 ++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 52 insertions(+)

Comment by Jonas Häggqvist (rasher) - Monday, 22 June 2009, 17:52 GMT+2
Fixes
- Reset dirlevel to 0, so pressing back returns to the menu.
Remaining bugs:
- None! :-)
   center_on_selected_FS#10093_v4.diff (2.3 KiB) 
 apps/tree.c |   54 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 54 insertions(+)

Comment by Jonas Häggqvist (rasher) - Monday, 22 June 2009, 18:17 GMT+2
Commit candidate:

Fixes:
- Remove the DEBUGF
Additions
- Change "Browse Fonts" into "Font"
- Change "Browse .wps files" into "While Playing Screen"
- Change "Browse .rwps files" into "Remote While Playing Screen"
- Change "Browse Themes" into "Browse Theme Files"
   center_on_selected_FS#10093_v5.diff (3.8 KiB) 
 apps/tree.c            |   53 +++++++++++++++++++++++++++++++++++++++++++++++++
 apps/lang/english.lang |   24 +++++++++++-----------
 2 files changed, 65 insertions(+), 12 deletions(-)

Comment by Jonas Häggqvist (rasher) - Monday, 22 June 2009, 19:29 GMT+2
Second commit candidate, I'll probably commit it shortly.

Additions
- Update the manual according to the menu wording changes.
   center_on_selected_FS#10093_v6.diff (7 KiB) 
 apps/tree.c                                 |   53 ++++++++++++++++++++++++++++
 apps/lang/english.lang                      |   24 ++++++------
 manual/advanced_topics/main.tex             |    6 +--
 manual/configure_rockbox/theme_settings.tex |    8 ++--
 4 files changed, 72 insertions(+), 19 deletions(-)

Loading...