Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10096 - rbutil: use selected mountpoint for installing ipod / sansa bootloader

Attached to Project: Rockbox
Opened by Dominik Riebeling (bluebrother) - Sunday, 05 April 2009, 00:12 GMT+1
Last edited by Dominik Riebeling (bluebrother) - Thursday, 30 April 2009, 21:14 GMT+1
Task Type Patches
Category Rbutil
Status Closed
Assigned To Dominik Riebeling (bluebrother)
Player Type All players
Severity Low
Priority Normal
Reported Version Version 3.2
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch modifies the installation for ipod and sansa bootloaders to not scan for a device (and use the one found) but use the one pointed to by the mountpoint. This is necessary if we add support for choosing from multiple detected devices (FS#9485) as otherwise having two ipods / sansas would make the bootloader installation fail. Furthermore, users should be able to expect that the correct player gets used if they chose from a list upon detection.

Issues of the current implementation:
- w32 only. I'm going to add linux support in a later version.
- if f.e. a sansa is connected with a wrong mountpoint set the bootloader gets first downloaded before an error (i.e. mountpoint not poining to the correct player) is detected. Not sure if this is that much of an issue as the only drawback is the additional download.
   rbutil-make-ipodpatcher-use-mountpoint02.patch (10.2 KiB) 
 base/autodetection.cpp          |   79 ++++++++++++++++++++++------------
 base/autodetection.h            |    1 
 base/bootloaderinstallipod.cpp  |   21 ++++++---
 base/bootloaderinstallsansa.cpp |   92 ++++++++++++++++------------------------
 base/bootloaderinstallsansa.h   |    1 
 5 files changed, 107 insertions(+), 87 deletions(-)

This task depends upon

Closed by  Dominik Riebeling (bluebrother)
Thursday, 30 April 2009, 21:14 GMT+1
Reason for closing:  Accepted
Additional comments about closing:  committed as r20832.
Comment by Dominik Riebeling (bluebrother) - Sunday, 05 April 2009, 16:08 GMT+1
Update:
- add support for Linux (OSX and BSD untested)
- sync against svn

Note: it looks like sansapatcher is behaving differently than ipodpatcher thus the forcing not working correctly. Further testing is needed.
   rbutil-make-patchers-use-mountpoint-03.diff (12.7 KiB) 
 b/rbutil/rbutilqt/base/autodetection.cpp          |  115 +++++++++++++++++-----
 b/rbutil/rbutilqt/base/autodetection.h            |    1 
 b/rbutil/rbutilqt/base/bootloaderinstallipod.cpp  |   41 ++++++-
 b/rbutil/rbutilqt/base/bootloaderinstallsansa.cpp |  100 ++++++++-----------
 b/rbutil/rbutilqt/base/bootloaderinstallsansa.h   |    1 
 5 files changed, 168 insertions(+), 90 deletions(-)

Comment by Dominik Riebeling (bluebrother) - Sunday, 05 April 2009, 16:46 GMT+1
Latest tests with two sansas showed that the device forcing is in fact working as expected but the debug output got me confused thus the above patch is complete in terms of functionality (except the untested OSes).

Loading...