Rockbox

Tasklist

FS#10108 - Use "gmake -r" and "make -r" as $make variables for rockboxdev.sh

Attached to Project: Rockbox
Opened by Robert Menes (RMenes379) - Wednesday, 08 April 2009, 22:08 GMT
Last edited by Robert Menes (RMenes379) - Monday, 13 April 2009, 22:12 GMT
Task Type Patches
Category Build environment
Status Closed
Assigned To Robert Menes (RMenes379)
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

This patch should fix any issues with people unable to build on some Unix systems. I needed to use this fix to get past some issues with Apple's gmake build in Mac OS X 10.5.6; using the -r option makes gmake and make ignore their own rules and use the rules set by rockboxdev.sh, allowing the dev environment to build.

This shouldn't break anything in Linux, but it's worth testing it before I blindly decide to commit it. Any users of other Unix or Unix-like systems (Solaris, *BSD, etc.) should also give this patch a try as well.
This task depends upon

Closed by  Robert Menes (RMenes379)
Monday, 13 April 2009, 22:12 GMT
Reason for closing:  Accepted
Additional comments about closing:  Committed.
Comment by Frank Gevaerts (fg) - Friday, 10 April 2009, 13:22 GMT
This seems to work here, on debian unstable 64bit
Comment by Thomas Martitz (kugel.) - Friday, 10 April 2009, 14:05 GMT
Works too on my ubuntu jaunty 32bit.
Comment by Robert Menes (RMenes379) - Friday, 10 April 2009, 19:38 GMT
So far so good. We need another *nix owner to chime in... preferably someone with FreeBSD, perhaps.
Comment by Thomas Martitz (kugel.) - Friday, 10 April 2009, 20:26 GMT
I guess you can wait ages for that.

I guess, if you want to play safe, you can apply this only to make and not gmake (unless mac has gmake).
Comment by Robert Menes (RMenes379) - Friday, 10 April 2009, 20:55 GMT
Mac OS X has gmake, hence the patch.

If it works for other Mac users as well, in it goes.

Loading...