Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10113 - Sansa AMS : do not use unaligned buffers on ATA DMA

Attached to Project: Rockbox
Opened by Rafaël Carré (funman) - Thursday, 09 April 2009, 15:43 GMT+2
Last edited by Thomas Martitz (kugel.) - Friday, 10 April 2009, 19:05 GMT+2
Task Type Patches
Category Drivers
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Version 3.2
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Fix fuze backdrop/wps corruption
md5sum plugin works correctly
test_disk passes

Transfer is a bit slower on unaligned access because al lthe data has to be memcpyed (1.25 times slower on 4096bytes transfers)
   0001-Sansa-AMS-ata-do-not-use-DMA-on-unaligned-bu... (3.6 KiB) 
 b/firmware/target/arm/as3525/ata_sd_as3525.c |   29 ++++++++++++++++++++++-----
 1 file changed, 24 insertions(+), 5 deletions(-)

This task depends upon

Closed by  Thomas Martitz (kugel.)
Friday, 10 April 2009, 19:05 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Committed in 20679. Thank you very much!
Comment by Thomas Martitz (kugel.) - Thursday, 09 April 2009, 22:26 GMT+2
I didn't test md5 or test disk, but the display corruption is gone.

Loading...