Rockbox

Tasklist

FS#10120 - fuze/e200v2: poll the wheel more often

Attached to Project: Rockbox
Opened by Thomas Martitz (kugel.) - Saturday, 11 April 2009, 03:12 GMT
Last edited by Thomas Martitz (kugel.) - Monday, 13 April 2009, 10:29 GMT
Task Type Patches
Category Drivers
Status Closed
Assigned To Thomas Martitz (kugel.)
Operating System All players
Severity Low
Priority Normal
Reported Version Version 3.2
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

This patch uses the tick_task timer to poll the scrollwheel every 5ms (the tick tasks stay at every 10ms of course).

This makes the scrollwheel on my fuze pretty much perfectly usable.

I'd like to hear opinions (from e200v2 owners too). It's a bit of a hack, but I'm fairly sure it cannot be done better (without an interrupt, that is), so I hope it's acceptable.
This task depends upon

Closed by  Thomas Martitz (kugel.)
Monday, 13 April 2009, 10:29 GMT
Reason for closing:  Accepted
Additional comments about closing:  Committed in r20699.
Comment by Dustin Skoracki (sko) - Saturday, 11 April 2009, 12:15 GMT
Works very good on my e250v2. A little cleanup for button-e200v2.c: scrollwheel(); is not necessary in button_read_device() because its called already through button_dbop() (which is called by button_read_device() ).
Comment by Thomas Martitz (kugel.) - Saturday, 11 April 2009, 12:31 GMT
Cool. And yes, you're correct :)
Comment by MichaelGiacomelli (saratoga) - Saturday, 11 April 2009, 22:09 GMT
Tried this out and it works nicely on my Fuze.
Comment by Thomas Martitz (kugel.) - Sunday, 12 April 2009, 02:00 GMT
No real functional change, just a bit of cleanup. And also add the comments for the dbp read function to the fuze driver.

Sadly, I cannot test anymore due to the lack of hardware. But if it works well, feel free to commit.
Comment by Dustin Skoracki (sko) - Sunday, 12 April 2009, 07:42 GMT
I can't compile it, get some errors: http://pastebin.com/d3bb99831
Comment by Thomas Martitz (kugel.) - Sunday, 12 April 2009, 12:38 GMT
There was a stupid typo :/
Comment by Dustin Skoracki (sko) - Sunday, 12 April 2009, 13:16 GMT
ok, now it's working again
Comment by Jack Halpin (FlynDice) - Monday, 13 April 2009, 04:55 GMT
Works fine on my e280v2. I dropped in the fuze scrollcode also and the scrolling action was perfectly acceptable. It wraps the menus always, which I personally tend to dislike, but the scrolling action was just fine. I did not need to change any parameters in the fuze scrollcode. It worked as is with only minor modifications to variable declarations so as not to redeclare.
Comment by Thomas Martitz (kugel.) - Monday, 13 April 2009, 10:19 GMT
You also needed to change "++count >= 4" to "++count >= 2", right?

Loading...