Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10124 - Fix some rbutil compilation warnings

Attached to Project: Rockbox
Opened by Tomer Shalev (tomers) - Saturday, 11 April 2009, 22:19 GMT+2
Last edited by Tomer Shalev (tomers) - Thursday, 01 October 2009, 07:27 GMT+2
Task Type Patches
Category Rbutil
Status Closed
Assigned To Dominik Riebeling (bluebrother)
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch eliminates some of the warnings that are shown during compilation of the Rockbox applications.

The patch includes:
- Wrapping 'if' blocks with curly brackets.
- Remove 'typedef' from struct declaration when nothing is typedef'ed to the struct.
   fix_compiler_warnings.diff (1.8 KiB) 
 rbutil/rbutilqt/rbutilqt.cpp     |    2 +-
 rbutil/rbutilqt/zip/unzip.cpp    |    2 ++
 rbutil/rbutilqt/zip/unzip.h      |    2 +-
 rbutil/rbutilqt/base/httpget.cpp |    3 ++-
 4 files changed, 6 insertions(+), 3 deletions(-)

This task depends upon

Closed by  Tomer Shalev (tomers)
Thursday, 01 October 2009, 07:27 GMT+2
Reason for closing:  Wont Fix
Comment by Dominik Riebeling (bluebrother) - Sunday, 12 April 2009, 20:05 GMT+2
can you please explain this patch? I don't get any warnings for the changed code at all, adding braces for one line statements isn't required at all and the typedef thing is in imported code which shouldn't be changed unless necessary IMO. Besides, we have one-line-statements without braces in quite a lot of places. If you get warnings here you should get a ton of other warnings as well.
Comment by Tomer Shalev (tomers) - Tuesday, 14 April 2009, 22:21 GMT+2
Please read attached console log file to look at the warnings I got.
My system details (compilers versions, Linux kernel versions) are here: http://pastebin.com/f29d14717
   rbutil_build_warnings.txt (65.4 KiB)

Loading...