Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10127 - Sansa e200v2: wrapping in menus

Attached to Project: Rockbox
Opened by Dustin Skoracki (sko) - Sunday, 12 April 2009, 11:00 GMT+2
Last edited by Thomas Martitz (kugel.) - Monday, 13 April 2009, 16:09 GMT+2
Task Type Patches
Category Drivers
Status Closed
Assigned To No-one
Player Type Sansa e200
Severity Low
Priority Normal
Reported Version Version 3.2
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch makes menus wrap if last/first item is reached. I compared the scrollwheel functions of the fuze and the e200v2 and took the handling of the repeat and wheel_delta variables from the fuze driver and implemented it to the e200v2 driver. I don't know if all these changes are necessary (i'm no C programmer), but it works fine.
   e200v2_wrap.diff (3 KiB) 
 firmware/target/arm/as3525/sansa-e200v2/button-e200v2.c |   31 +++++++++++-----
 1 file changed, 23 insertions(+), 8 deletions(-)

This task depends upon

Closed by  Thomas Martitz (kugel.)
Monday, 13 April 2009, 16:09 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Committed in r20700. Good job and thanks!
Comment by Thomas Martitz (kugel.) - Sunday, 12 April 2009, 19:48 GMT+2
Good Work. I'm wondering if the code can be more cleaned up and be made like the fuze's driver.

PS: We need your full real name if you want this to be committed.
Comment by Dustin Skoracki (sko) - Sunday, 12 April 2009, 20:17 GMT+2
Well, I tried to use the whole scrollwheel() function of the fuze driver, but it is not as good as this one on the e200v2. With the function of the fuze driver it is possible that the next menu item is not selected if the wheel is turned very slow, with the one in the e200v2 driver (and your patch  FS#10120 ) its perfect I think: one physical click scrolls one item.
Comment by Thomas Martitz (kugel.) - Sunday, 12 April 2009, 20:19 GMT+2
Well, the fuze needs to skip 4 queue_posts while the e200 needs only 2 (see "++count >= 4 &&...." vs "else if (++wheel_click_count < 2)" which is why it skipped items for you. Try changing to ++count >= 2 if you insert the fuze's one.
Comment by Thomas Martitz (kugel.) - Monday, 13 April 2009, 12:30 GMT+2
Ok, I committed  FS#10120 .

Do you have found a way to make it not always wrap, but only if you reach the end/beginning slowly?
Comment by Dustin Skoracki (sko) - Monday, 13 April 2009, 13:12 GMT+2
Is it wrapping on fuze only if it's slow? I wonder if this is driver-related. The menu should only wrap if there is no BUTTON_REPEAT, so can it be related to the keymap?
Anyway, I made it more like the fuze driver... maybe in a different way than you expected: the wheel is working perfectly with the fuze's scrollwheel function if the skip count is 2 instead of 4, so I put the scrollwheel function out of the driver files into a extra file, so both are using the same code (was just an idea to avoid redundancies in the code) .
   unify_scrollwheel-e200v2-fuze.diff (13.9 KiB) 
 firmware/SOURCES                                        |    2 
 firmware/target/arm/as3525/sansa-e200v2/button-e200v2.c |  145 ----------------
 firmware/target/arm/as3525/scrollwheel-e200v2-fuze.c    |  110 ++++++++++++
 firmware/target/arm/as3525/sansa-fuze/button-fuze.c     |   83 ---------
 4 files changed, 122 insertions(+), 218 deletions(-)

Comment by Thomas Martitz (kugel.) - Monday, 13 April 2009, 13:15 GMT+2
Right. On the Fuze it only wraps if you turn the wheel slowly (which means there's no BUTTON_REPEAT). And it should work like that on the e200 too (if possible).

Edit: Combining both drivers entirely would also be reasonable. The scrollwheel function is the only real difference.
Comment by Dustin Skoracki (sko) - Monday, 13 April 2009, 15:04 GMT+2
Ok, thanks to kugel here is a patch which wraps only if the wheel is turned slowly. The scrollwheel function is back in the driver file because of the changes. If someone wants to commit: my real name is Dustin Skoracki.
   e200v2_wrap_02.diff (7.9 KiB) 
 firmware/target/arm/as3525/sansa-e200v2/button-e200v2.c |  174 +++++-----------
 1 file changed, 59 insertions(+), 115 deletions(-)

Loading...