Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10137 - Rockbox Theme Site Rollover Images

Attached to Project: Rockbox
Opened by Maurus Cuelenaere (mcuelenaere) - Friday, 17 April 2009, 12:51 GMT+2
Last edited by Maurus Cuelenaere (mcuelenaere) - Monday, 15 June 2009, 21:16 GMT+2
Task Type Patches
Category Themes
Status Closed
Assigned To No-one
Player Type Another
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch adds rollover images to themes which have a menu screenshot next to the regular WPS screenshot.
   rollover.diff (3 KiB) 
 public/rbscript.js              |   37 +++++++++++++++++++++++++++++++++++++
 private/templates/header.tpl    |    1 +
 private/templates/themelist.tpl |    7 ++++++-
 private/templates/TODO          |    1 -
 4 files changed, 44 insertions(+), 2 deletions(-)

This task depends upon

Closed by  Maurus Cuelenaere (mcuelenaere)
Monday, 15 June 2009, 21:16 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  In r21297.
Comment by Jonas Häggqvist (rasher) - Saturday, 18 April 2009, 22:30 GMT+2
Nice, unfortunately we have this:
+// Distributed under Creative Commons

Which isn't really clear, since it could be any one of a number of licenses. Some of which don't even allow derivative works.
Comment by Maurus Cuelenaere (mcuelenaere) - Wednesday, 22 April 2009, 14:32 GMT+2
I mailed the author of the script regarding this and he responded with this (21/4/2009):

Hi Maurus. I'm sorry it isn't clear, but I don't have any restrictions
on how you use that script. I will try to update it soon to make that
a little more obvious.

---
Jehiah
http://jehiah.cz/
Comment by Maurus Cuelenaere (mcuelenaere) - Thursday, 11 June 2009, 15:01 GMT+2
As the original author doesn't respond to my mails anymore, I decided to rewrite the script.
   rockbox_themesite_rollover.diff (3.7 KiB) 
 private/templates/header.tpl    |    1 
 private/templates/themelist.tpl |    7 ++++-
 private/templates/TODO          |    1 
 public/rbscript.js              |   54 ++++++++++++++++++++++++++++++++++++++++
 4 files changed, 61 insertions(+), 2 deletions(-)

Loading...