Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10141 - Modify AMS Sansa #defines in plugin.lds to account for as3525 MEMORYSIZE > 2

Attached to Project: Rockbox
Opened by Jack Halpin (FlynDice) - Saturday, 18 April 2009, 17:54 GMT+2
Last edited by Thomas Martitz (kugel.) - Monday, 20 April 2009, 22:25 GMT+2
Task Type Patches
Category Configuration
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Version 3.2
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This corrects the DRAMSIZE define for as3525 memorysize >2 and adds some whitespace to make the code for other targets more readable. As it is the as3525 mem > 2 and everything below are getting this DRAMSIZE define. I don't see any other DRAMSIZE defines so there is a chance that this was intentional but it appears to be just an oversight. Compiles and runs fine on my e280v2.
   AS3525_plugin.lds.patch (2 KiB) 
 apps/plugins/plugin.lds |   13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

This task depends upon

Closed by  Thomas Martitz (kugel.)
Monday, 20 April 2009, 22:25 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Committed in r20760. Thanks!
Comment by Dustin Skoracki (sko) - Sunday, 19 April 2009, 17:42 GMT+2
Works on my e250v2. Should there be any noticable differences to build without that patch?
Comment by Rafaël Carré (funman) - Monday, 20 April 2009, 16:37 GMT+2
no difference, just cosmetic and clarity.
OK for commit.

Loading...