Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Configuration
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Version 3.2
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by FlynDice - 2009-04-18
Last edited by kugel. - 2009-04-20

FS#10141 - Modify AMS Sansa #defines in plugin.lds to account for as3525 MEMORYSIZE > 2

This corrects the DRAMSIZE define for as3525 memorysize >2 and adds some whitespace to make the code for other targets more readable. As it is the as3525 mem > 2 and everything below are getting this DRAMSIZE define. I don’t see any other DRAMSIZE defines so there is a chance that this was intentional but it appears to be just an oversight. Compiles and runs fine on my e280v2.

   AS3525_plugin.lds.patch (2 KiB)
Closed by  kugel.
2009-04-20 20:25
Reason for closing:  Accepted
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Committed in r20760. Thanks!

sko commented on 2009-04-19 15:42

Works on my e250v2. Should there be any noticable differences to build without that patch?

funman commented on 2009-04-20 14:37

no difference, just cosmetic and clarity.
OK for commit.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing