Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10146 - USB: Pass to the USB classes a pointer to USB core buffer

Attached to Project: Rockbox
Opened by Tomer Shalev (tomers) - Saturday, 18 April 2009, 22:15 GMT+2
Last edited by Frank Gevaerts (fg) - Saturday, 18 April 2009, 22:42 GMT+2
Task Type Patches
Category Drivers
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This is one of the changes made in  FS#10116 .

This patch is an infrastructure to allow USB classes to send data using the USB core's statically allocated buffer:
static unsigned char response_data[256] USB_DEVBSS_ATTR;

This is needed in the soon-to-be-committed HID class driver.
   use_usb_core_buffer_in_classes.diff (3.4 KiB) 
 firmware/usbstack/usb_class_driver.h |    2 +-
 firmware/usbstack/usb_serial.h       |    2 +-
 firmware/usbstack/usb_serial.c       |    4 +++-
 firmware/usbstack/usb_storage.h      |    2 +-
 firmware/usbstack/usb_storage.c      |    4 ++--
 firmware/usbstack/usb_core.c         |    2 +-
 6 files changed, 9 insertions(+), 7 deletions(-)

This task depends upon

Closed by  Frank Gevaerts (fg)
Saturday, 18 April 2009, 22:42 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  committed as r20735
Comment by Tomer Shalev (tomers) - Saturday, 18 April 2009, 22:28 GMT+2
Updated patch. Fixed compilation error discovered by gevaerts.
   use_usb_core_buffer_in_classes.diff (4.5 KiB) 
 firmware/usbstack/usb_class_driver.h |    2 +-
 firmware/usbstack/usb_serial.h       |    2 +-
 firmware/usbstack/usb_serial.c       |    4 +++-
 firmware/usbstack/usb_storage.h      |    2 +-
 firmware/usbstack/usb_storage.c      |    4 ++--
 firmware/usbstack/usb_core.c         |   10 ++++++----
 6 files changed, 14 insertions(+), 10 deletions(-)

Comment by Tomer Shalev (tomers) - Saturday, 18 April 2009, 22:33 GMT+2
This one should do it!
   use_usb_core_buffer_in_classes.diff (4.5 KiB) 
 firmware/usbstack/usb_class_driver.h |    2 +-
 firmware/usbstack/usb_serial.h       |    2 +-
 firmware/usbstack/usb_serial.c       |    4 +++-
 firmware/usbstack/usb_storage.h      |    2 +-
 firmware/usbstack/usb_storage.c      |    4 ++--
 firmware/usbstack/usb_core.c         |   10 ++++++----
 6 files changed, 14 insertions(+), 10 deletions(-)

Loading...