Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10149 - USB: Serial code reorder

Attached to Project: Rockbox
Opened by Tomer Shalev (tomers) - Sunday, 19 April 2009, 20:25 GMT+2
Last edited by Frank Gevaerts (fg) - Sunday, 19 April 2009, 21:54 GMT+2
Task Type Patches
Category Drivers
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch makes the serial USB driver code cleaner and more readable.

Note: This code compiles, but have yet to be really tested (I don't have the proper setup, as I use a virtual Ubuntu machine, and using real USB device in the guest OS is really buggy in VirtualBox).

Please test serial USB still works before committing!
   serial_code_reorder.diff (3.5 KiB)
 firmware/usbstack/usb_serial.c |   64 +++++++++++++++++------------------------
 1 file changed, 28 insertions(+), 36 deletions(-)

This task depends upon

Closed by  Frank Gevaerts (fg)
Sunday, 19 April 2009, 21:54 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  committed as r20746

Loading...