Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10151 - e200v2: scrollwheel acceleration

Attached to Project: Rockbox
Opened by Dustin Skoracki (sko) - Sunday, 19 April 2009, 22:09 GMT+2
Last edited by Thomas Martitz (kugel.) - Wednesday, 29 April 2009, 22:50 GMT+2
Task Type Patches
Category Drivers
Status Closed
Assigned To No-one
Player Type Sansa e200
Severity Low
Priority Normal
Reported Version Version 3.2
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch by kugel and me enables scrollwheel acceleration for the e200v2: fast wheel turning will cause lists to jump over items for fast scrolling.
   e200v2_scrollwheel_acceleration.diff (3.5 KiB) 
 firmware/target/arm/as3525/sansa-e200v2/button-e200v2.c |   42 ++++++++--------
 1 file changed, 23 insertions(+), 19 deletions(-)

This task depends upon

Closed by  Thomas Martitz (kugel.)
Wednesday, 29 April 2009, 22:50 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Committed in r20822. Good work!
Comment by Dustin Skoracki (sko) - Tuesday, 21 April 2009, 21:08 GMT+2
Here is a new patch, it's compiling again (old patch didn't work since r20757), has a little faster acceleration and is more simple.
   e200v2_scrollwheel_acceleration_02.diff (2 KiB) 
 firmware/target/arm/as3525/sansa-e200v2/button-e200v2.c |   18 ++++++++++++----
 1 file changed, 14 insertions(+), 4 deletions(-)

Comment by Dustin Skoracki (sko) - Thursday, 23 April 2009, 16:35 GMT+2
New one: a little more time between to wheelclicks to be recognized as repeat and a little comment change to make it more clear.
   e200v2_scrollwheel_acceleration_03.diff (2 KiB) 
 firmware/target/arm/as3525/sansa-e200v2/button-e200v2.c |   20 ++++++++++++----
 1 file changed, 15 insertions(+), 5 deletions(-)

Comment by Michael Chicoine (mc2739) - Thursday, 23 April 2009, 23:22 GMT+2
Seems to work well on my e260v2
Comment by Thomas Martitz (kugel.) - Sunday, 26 April 2009, 13:09 GMT+2
During a missed read, you're not executing scrollwheel(), is that intended? I'd think you get more smooth acceleration if you executed it anyway (it'll give the same button, but increase repeat).
Comment by Dustin Skoracki (sko) - Sunday, 26 April 2009, 14:46 GMT+2
Yes, at the last try it was intended, but it worked not as good as the first try, so, here is a new patch which executes scrollwheel during a missed read (very similar to first patch).
   e200v2_scrollwheel_acceleration_04.diff (3.8 KiB) 
 firmware/target/arm/as3525/sansa-e200v2/button-e200v2.c |   50 +++++++++-------
 1 file changed, 29 insertions(+), 21 deletions(-)

Comment by Dustin Skoracki (sko) - Sunday, 26 April 2009, 20:14 GMT+2
This is basically the same patch than the one before, but with imo better acceleration behavior.
   e200v2_scrollwheel_acceleration_04b.diff (3.8 KiB) 
 firmware/target/arm/as3525/sansa-e200v2/button-e200v2.c |   50 +++++++++-------
 1 file changed, 29 insertions(+), 21 deletions(-)

Loading...