Rockbox

Tasklist

FS#10166 - USB arrangement - use constants and some cosmetics

Attached to Project: Rockbox
Opened by Tomer Shalev (tomers) - Saturday, 25 April 2009, 17:05 GMT
Last edited by Frank Gevaerts (fg) - Saturday, 23 May 2009, 15:10 GMT
Task Type Patches
Category Drivers
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

This patch contains the following:

1. Use some constants to make code clearer.
2. Some cosmetics
3. Remove redundant definitions of various places which are similar to those in ch9.h and other headers.
4. Add some verbosity (logf) in usb-drv-arc.c
This task depends upon

Closed by  Frank Gevaerts (fg)
Saturday, 23 May 2009, 15:10 GMT
Reason for closing:  Out of Date
Comment by Frank Gevaerts (fg) - Saturday, 25 April 2009, 18:31 GMT
Some comments:
- usb_drv_request_endpoint() gets a new type parameter which isn't used anywhere else. Included here by accident?
- you remove EPCTRL_EP_TYPE_ISO and friends in usb-drv-arc.c without adding them elsewhere or updating the places that use them
- usb.c contains non-style things (the usb_core_enable_driver(USB_DRIVER_HID, false) lines). Are they supposed to be included here? (I don't object to them, I just think they belong in a different commit)

In general though, are all the indentation and whitespace changes really needed? In some places, you actually change the indentation style (e.g. usb.c), something that docs/CONTRIBUTING specifically asks not to do.
Comment by Tomer Shalev (tomers) - Sunday, 26 April 2009, 22:21 GMT
Fixed patch.
- Removed changes that belong to future patches.
- EPCTRL_EP_TYPE_XXX no replaced with USB_ENDPOINT_XFER_XXX which is defined in usb_ch9.h
- Removed most cosmetics changes.

Loading...