Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10181 - Allow the FM region to be set from a FMR file

Attached to Project: Rockbox
Opened by Alexander Levin (fml2) - Friday, 01 May 2009, 23:29 GMT+1
Task Type Patches
Category FM Tuner
Status New
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Version 3.2
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Private No

Details

Since FM stations list may require that the FM region is set to a certain value, it would be good if the FM region could be set along with the station list. The patch does just that.

The region is set by putting the line "region:N" into the FMR file (at any line there). N can be one of the values allowed for the fm_region setting.

The patch does not work on the simulators for e200 and h120 (the only two I tried) because, for some reason, the symbol HAVE_RADIO_REGION is not defined for them. Could anybody tell why?

Saving the region along with the station list is not implemented.
   fmr-with-region.patch (1.8 KiB) 
 apps/recorder/radio.c |   29 ++++++++++++++++++++++-------
 1 file changed, 22 insertions(+), 7 deletions(-)

This task depends upon

Comment by Alexander Levin (fml2) - Thursday, 14 May 2009, 15:40 GMT+1
Slightly modified the patch so that is also works in the simulator. Separating the fm_region setting (making its presence depending on HAVE_RADIO_REGION) has proven to be a more complicated task that I thought because it's woven deeply in the code (some pieces of code use fm_region structure regardless whether the REGION capability is present or not).

Please comment since I think it's a cute feature (having region in fmr file).
   fmr-with-region2.patch (2.1 KiB) 
 apps/recorder/radio.c   |   22 +++++++++++++++-------
 firmware/export/tuner.h |    7 +++++--
 2 files changed, 20 insertions(+), 9 deletions(-)

Loading...