Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10214 - Pure Data for Rockbox plugin

Attached to Project: Rockbox
Opened by Wincent Balin (wincent) - Sunday, 17 May 2009, 01:33 GMT+2
Last edited by Peter D'Hoye (petur) - Friday, 22 May 2009, 23:59 GMT+2
Task Type Patches
Category Plugins
Status Closed
Assigned To No-one
Player Type SW-codec
Severity Low
Priority Normal
Reported Version Version 3.2
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This is a GSoC 2009 (and beyond) project about porting Pure Data audio framework to Rockbox. With a simple GUI around it will allow to turn a DAP into a portable synthesizer, effect device or any audio processing gadget you wish.
   pdbox-initial.patch (15.1 KiB) 
 apps/plugins/pdbox/pdbox-net.c |  119 +++++++++++++++++++++++++++++
 apps/plugins/pdbox/pdbox.h     |   71 +++++++++++++++++
 apps/plugins/pdbox/SOURCES     |  165 +++++++++++++++++++++++++++++++++++++++++
 apps/plugins/pdbox/pdbox.make  |   31 +++++++
 apps/plugins/pdbox/pdbox.c     |  157 +++++++++++++++++++++++++++++++++++++++
 5 files changed, 543 insertions(+)

This task depends upon

Closed by  Peter D'Hoye (petur)
Friday, 22 May 2009, 23:59 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  and now, your changes.. :)
Comment by Peter D'Hoye (petur) - Monday, 18 May 2009, 12:13 GMT+2
great! I'll check it as soon as I can...
Comment by Dominik Wenger (Domonoky) - Monday, 18 May 2009, 18:20 GMT+2
A few general Comments. I will take a deeper look, when i find time.

- The patch isnt complete, all the unmodified files from PDa (and others) are missing in the patch. (you have to svn add them, to get them included into svn diff)
- You should add a README.rockbox which contains the details about the imported code (exact version, licence, etc) and your modifications.
- It would be a good Idea to divide that into a few patches. Like one patch for unmodified PDa (not enabled for compiling) then a patch (or many) with the different modifications needed for compiling, etc.

Comment by Wincent Balin (wincent) - Monday, 18 May 2009, 19:15 GMT+2
Here are the patches for dbestfit and PDa, both unmodified.
   dbestfit-initial.patch (65.9 KiB) 
 apps/plugins/pdbox/dbestfit-3.3/malloc.man |   95 +++
 apps/plugins/pdbox/dbestfit-3.3/bysize.c   |  424 +++++++++++++++++
 apps/plugins/pdbox/dbestfit-3.3/Malloc.c   |  201 ++++++++
 apps/plugins/pdbox/dbestfit-3.3/bmalloc.c  |  370 +++++++++++++++
 apps/plugins/pdbox/dbestfit-3.3/bysize.h   |    4 
 apps/plugins/pdbox/dbestfit-3.3/dmalloc.c  |  690 +++++++++++++++++++++++++++++
 apps/plugins/pdbox/dbestfit-3.3/README     |   22 
 apps/plugins/pdbox/dbestfit-3.3/bmalloc.h  |    6 
 apps/plugins/pdbox/dbestfit-3.3/dmalloc.h  |    8 
 apps/plugins/pdbox/dbestfit-3.3/FILES      |   15 
 apps/plugins/pdbox/dbestfit-3.3/thoughts   |  170 +++++++
 apps/plugins/pdbox/dbestfit-3.3/mytest.c   |   70 ++
 apps/plugins/pdbox/dbestfit-3.3/CHANGES    |   12 
 apps/plugins/pdbox/dbestfit-3.3/dmytest.c  |  138 +++++
 apps/plugins/pdbox/dbestfit-3.3/Makefile   |   38 +
 15 files changed, 2263 insertions(+)

(application/x-gzip)    pda-initial.patch.gz (753.4 KiB)
Comment by Peter D'Hoye (petur) - Thursday, 21 May 2009, 00:19 GMT+2
Wincent, the patch misses the addition into the rockbox make system (adding your patches doesn't cause them to get build)

If I do that (see attached patch) it turns out this code doesn't build and even misses some files:

CC apps/plugins/pdbox/pdbox.c
/home/peter/rockbox/gsoc/2009/dev1/apps/plugins/pdbox/pdbox.c: In function `plugin_start':
/home/peter/rockbox/gsoc/2009/dev1/apps/plugins/pdbox/pdbox.c:102: warning: unused variable `mem_size'
/home/peter/rockbox/gsoc/2009/dev1/apps/plugins/pdbox/pdbox.c:103: warning: unused variable `mem_pool'
/home/peter/rockbox/gsoc/2009/dev1/apps/plugins/pdbox/pdbox.c:106: warning: unused variable `filename'
CC apps/plugins/pdbox/pdbox-net.c
CC apps/plugins/pdbox/PDa/src/m_fixed.c
/home/peter/rockbox/gsoc/2009/dev1/apps/plugins/pdbox/PDa/src/m_fixed.c:2:24: sys/socket.h: No such file or directory
/home/peter/rockbox/gsoc/2009/dev1/apps/plugins/pdbox/PDa/src/m_fixed.c:3:24: netinet/in.h: No such file or directory
/home/peter/rockbox/gsoc/2009/dev1/apps/plugins/pdbox/PDa/src/m_fixed.c:4:25: netinet/tcp.h: No such file or directory
/home/peter/rockbox/gsoc/2009/dev1/apps/plugins/pdbox/PDa/src/m_fixed.c:5:19: netdb.h: No such file or directory
/home/peter/rockbox/gsoc/2009/dev1/apps/plugins/pdbox/PDa/src/m_fixed.c:25: warning: function declaration isn't a prototype
/home/peter/rockbox/gsoc/2009/dev1/apps/plugins/pdbox/PDa/src/m_fixed.c: In function `ipod_connect':
/home/peter/rockbox/gsoc/2009/dev1/apps/plugins/pdbox/PDa/src/m_fixed.c:26: error: storage size of 'server' isn't known
/home/peter/rockbox/gsoc/2009/dev1/apps/plugins/pdbox/PDa/src/m_fixed.c:39: warning: implicit declaration of function `socket'
/home/peter/rockbox/gsoc/2009/dev1/apps/plugins/pdbox/PDa/src/m_fixed.c:39: error: `AF_INET' undeclared (first use in this function)
/home/peter/rockbox/gsoc/2009/dev1/apps/plugins/pdbox/PDa/src/m_fixed.c:39: error: (Each undeclared identifier is reported only once
/home/peter/rockbox/gsoc/2009/dev1/apps/plugins/pdbox/PDa/src/m_fixed.c:39: error: for each function it appears in.)
/home/peter/rockbox/gsoc/2009/dev1/apps/plugins/pdbox/PDa/src/m_fixed.c:39: error: `SOCK_DGRAM' undeclared (first use in this function)
/home/peter/rockbox/gsoc/2009/dev1/apps/plugins/pdbox/PDa/src/m_fixed.c:43: warning: implicit declaration of function `sys_sockerror'
/home/peter/rockbox/gsoc/2009/dev1/apps/plugins/pdbox/PDa/src/m_fixed.c:50: warning: implicit declaration of function `gethostbyname'
/home/peter/rockbox/gsoc/2009/dev1/apps/plugins/pdbox/PDa/src/m_fixed.c:50: warning: assignment makes pointer from integer without a cast
/home/peter/rockbox/gsoc/2009/dev1/apps/plugins/pdbox/PDa/src/m_fixed.c:57: warning: implicit declaration of function `memcpy'
/home/peter/rockbox/gsoc/2009/dev1/apps/plugins/pdbox/PDa/src/m_fixed.c:57: error: dereferencing pointer to incomplete type
/home/peter/rockbox/gsoc/2009/dev1/apps/plugins/pdbox/PDa/src/m_fixed.c:57: error: dereferencing pointer to incomplete type
/home/peter/rockbox/gsoc/2009/dev1/apps/plugins/pdbox/PDa/src/m_fixed.c:59: warning: implicit declaration of function `htons'
/home/peter/rockbox/gsoc/2009/dev1/apps/plugins/pdbox/PDa/src/m_fixed.c:59: error: `u_short' undeclared (first use in this function)
/home/peter/rockbox/gsoc/2009/dev1/apps/plugins/pdbox/PDa/src/m_fixed.c:59: error: syntax error before "portno"
/home/peter/rockbox/gsoc/2009/dev1/apps/plugins/pdbox/PDa/src/m_fixed.c:60: warning: implicit declaration of function `connect'
/home/peter/rockbox/gsoc/2009/dev1/apps/plugins/pdbox/PDa/src/m_fixed.c:63: warning: implicit declaration of function `sys_closesocket'
/home/peter/rockbox/gsoc/2009/dev1/apps/plugins/pdbox/PDa/src/m_fixed.c:26: warning: unused variable `server'
/home/peter/rockbox/gsoc/2009/dev1/apps/plugins/pdbox/PDa/src/m_fixed.c:31: warning: unused variable `intarg'
/home/peter/rockbox/gsoc/2009/dev1/apps/plugins/pdbox/PDa/src/m_fixed.c: In function `ipod_bang':
/home/peter/rockbox/gsoc/2009/dev1/apps/plugins/pdbox/PDa/src/m_fixed.c:75: warning: implicit declaration of function `sprintf'
/home/peter/rockbox/gsoc/2009/dev1/apps/plugins/pdbox/PDa/src/m_fixed.c:76: warning: implicit declaration of function `send'
/home/peter/rockbox/gsoc/2009/dev1/apps/plugins/pdbox/PDa/src/m_fixed.c:76: warning: implicit declaration of function `strlen'
/home/peter/rockbox/gsoc/2009/dev1/apps/plugins/pdbox/PDa/src/m_fixed.c: In function `pd_checkgui':
/home/peter/rockbox/gsoc/2009/dev1/apps/plugins/pdbox/PDa/src/m_fixed.c:111: warning: implicit declaration of function `strncmp'
/home/peter/rockbox/gsoc/2009/dev1/apps/plugins/pdbox/PDa/src/m_fixed.c:112: warning: implicit declaration of function `strcmp'
make: *** [/home/peter/rockbox/gsoc/2009/dev1/build/apps/plugins/pdbox/PDa/src/m_fixed.o] Error 1
   add_to_subdirs.patch (0.3 KiB) 
 apps/plugins/SUBDIRS |    1 +
 1 file changed, 1 insertion(+)

Comment by Wincent Balin (wincent) - Thursday, 21 May 2009, 01:44 GMT+2
Here is the patch for the build system
   buildsystem.patch (1 KiB) 
 apps/plugins/CATEGORIES     |    1 +
 apps/plugins/SUBDIRS        |    1 +
 apps/plugins/viewers.config |    3 ++-
 3 files changed, 4 insertions(+), 1 deletion(-)

Comment by Wincent Balin (wincent) - Thursday, 21 May 2009, 02:17 GMT+2
Here is the correct version of the pdbox initial patch
   pdbox-initial.patch (15.1 KiB) 
 apps/plugins/pdbox/SOURCES     |  167 +++++++++++++++++++++++++++++++++++++++++
 apps/plugins/pdbox/pdbox-net.c |  119 +++++++++++++++++++++++++++++
 apps/plugins/pdbox/pdbox.c     |  157 ++++++++++++++++++++++++++++++++++++++
 apps/plugins/pdbox/pdbox.h     |   71 +++++++++++++++++
 apps/plugins/pdbox/pdbox.make  |   31 +++++++
 5 files changed, 545 insertions(+)

Loading...