FS#10227 : Add clarifying comment in usb-drv-arc.c

Status Closed
Percent Complete
100%
Task Type Patches
Category Drivers
Assigned To No-one
Operating System All players
Severity Low
Priority Very Low
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Votes
Private

Attached to Project: Rockbox
Opened by tomers - 2009-05-22
Last edited by fg - 2009-05-23

FS#10227 - Add clarifying comment in usb-drv-arc.c

Add the following comment to the code:

“manual: 32.9.5.18 (Caution): Leaving an unconfigured endpoint control will cause undefined behavior for the data pid tracking on the active endpoint/direction.”

Also minor cosmetic changes.

usb-drv-arc-comment.diff (1.3 KiB)

Closed by fg
2009-05-23 14:50
Reason for closing: Accepted
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Committed as r21055

Comments (2)
Related Tasks (0/0)

fg commented on 2009-05-22 23:33

Actually, I'd prefer fixing the code to actually avoid this undefined behaviour. I'll try to have a go at this soon.

fg commented on 2009-05-23 14:49

I didn't read this properly, there is indeed nothing to fix. I'll commit

	Tasks related to this task (0)

Loading...

Keyboard shortcuts

Available keyboard shortcuts

Alt + ⇧ Shift + l Login Dialog / Logout
Alt + ⇧ Shift + a Add new task
Alt + ⇧ Shift + m My searches
Alt + ⇧ Shift + t focus taskid search

Tasklist

o open selected task
j move cursor down
k move cursor up

Task Details

n Next task
p Previous task
Alt + ⇧ Shift + e ↵ Enter Edit this task
Alt + ⇧ Shift + w watch task
Alt + ⇧ Shift + y Close Task

Task Editing

Alt + ⇧ Shift + s save task