Rockbox

Tasklist

FS#10227 - Add clarifying comment in usb-drv-arc.c

Attached to Project: Rockbox
Opened by Tomer Shalev (tomers) - Friday, 22 May 2009, 04:37 GMT
Last edited by Frank Gevaerts (fg) - Saturday, 23 May 2009, 14:50 GMT
Task Type Patches
Category Drivers
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Add the following comment to the code:

"manual: 32.9.5.18 (Caution): Leaving an unconfigured endpoint control will cause undefined behavior for the data pid tracking on the active endpoint/direction."

Also minor cosmetic changes.
This task depends upon

Closed by  Frank Gevaerts (fg)
Saturday, 23 May 2009, 14:50 GMT
Reason for closing:  Accepted
Additional comments about closing:  Committed as r21055
Comment by Frank Gevaerts (fg) - Friday, 22 May 2009, 23:33 GMT
Actually, I'd prefer fixing the code to actually avoid this undefined behaviour. I'll try to have a go at this soon.
Comment by Frank Gevaerts (fg) - Saturday, 23 May 2009, 14:49 GMT
I didn't read this properly, there is indeed nothing to fix. I'll commit

Loading...