Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10227 - Add clarifying comment in usb-drv-arc.c

Attached to Project: Rockbox
Opened by Tomer Shalev (tomers) - Friday, 22 May 2009, 06:37 GMT+2
Last edited by Frank Gevaerts (fg) - Saturday, 23 May 2009, 16:50 GMT+2
Task Type Patches
Category Drivers
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Add the following comment to the code:

"manual: 32.9.5.18 (Caution): Leaving an unconfigured endpoint control will cause undefined behavior for the data pid tracking on the active endpoint/direction."

Also minor cosmetic changes.
   usb-drv-arc-comment.diff (1.3 KiB) 
 firmware/target/arm/usb-drv-arc.c |   14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

This task depends upon

Closed by  Frank Gevaerts (fg)
Saturday, 23 May 2009, 16:50 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Committed as r21055
Comment by Frank Gevaerts (fg) - Saturday, 23 May 2009, 01:33 GMT+2
Actually, I'd prefer fixing the code to actually avoid this undefined behaviour. I'll try to have a go at this soon.
Comment by Frank Gevaerts (fg) - Saturday, 23 May 2009, 16:49 GMT+2
I didn't read this properly, there is indeed nothing to fix. I'll commit

Loading...