Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10232 - remove delete button in bookmark list

Attached to Project: Rockbox
Opened by Johannes Linke (Jaykay) - Friday, 22 May 2009, 18:53 GMT+2
Task Type Patches
Category User Interface
Status Unconfirmed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Version 3.2
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Private No

Details

i asked some time ago why there is the buttontable in general settings -->bookmark. i wondered because the buttons are the same as in other lists. Marc Guay said "the delete button is unique", an i wondered why there is a dedicated delete button... in no other lists exists such a button afaik.

i changed the manual accordingly.
i also corrected some wrong (?) comments.
i hope i did everything right, at least for the e200 it compiles and works fine.


i would like to get some opinions about it.
   bookmark.diff (22.2 KiB) 
 apps/keymaps/keymap-m3.c                 |    8 ++------
 apps/keymaps/keymap-creativezv.c         |    1 -
 apps/keymaps/keymap-h1x0_h3x0.c          |    9 ++++-----
 apps/keymaps/keymap-ifp7xx.c             |    3 +--
 apps/keymaps/keymap-iaudio67.c           |    2 --
 apps/keymaps/keymap-player.c             |    4 +---
 apps/keymaps/keymap-creativezvm.c        |    1 -
 apps/keymaps/keymap-c100.c               |    2 --
 apps/keymaps/keymap-gigabeat.c           |    2 --
 apps/keymaps/keymap-gigabeat-s.c         |    4 ----
 apps/keymaps/keymap-c200.c               |    2 --
 apps/keymaps/keymap-recorder.c           |    5 +----
 apps/keymaps/keymap-e200.c               |    2 --
 apps/keymaps/keymap-sa9200.c             |    2 --
 apps/keymaps/keymap-m200.c               |    2 --
 apps/keymaps/keymap-clip.c               |    2 --
 apps/keymaps/keymap-h10.c                |    1 -
 apps/keymaps/keymap-av300.c              |    5 +----
 apps/keymaps/keymap-ipod.c               |    3 +--
 apps/keymaps/keymap-x5.c                 |    4 +---
 apps/keymaps/keymap-mr100.c              |    2 --
 apps/keymaps/keymap-logikdax.c           |    2 --
 apps/keymaps/keymap-meizu-m6sl.c         |    2 --
 apps/keymaps/keymap-ondio.c              |    4 +---
 apps/keymaps/keymap-hdd1630.c            |    2 --
 apps/keymaps/keymap-fuze.c               |    2 --
 manual/platform/keymap-h100_h300.tex     |    3 ---
 manual/platform/keymap-ondio.tex         |    4 ----
 manual/platform/keymap-gigabeatf.tex     |    3 ---
 manual/platform/keymap-mrobe100.tex      |    3 ---
 manual/platform/keymap-ipod4g.tex        |    3 ---
 manual/platform/keymap-gigabeats.tex     |    3 ---
 manual/platform/keymap-player.tex        |    3 ---
 manual/platform/keymap-c200.tex          |    4 ----
 manual/platform/keymap-recorder.tex      |    2 --
 manual/platform/keymap-e200.tex          |    4 ----
 manual/platform/keymap-mx5.tex           |    3 ---
 manual/platform/keymap-ipod3g.tex        |    3 ---
 manual/platform/keymap-h10.tex           |    4 ----
 manual/configure_rockbox/bookmarking.tex |   22 +---------------------
 40 files changed, 14 insertions(+), 128 deletions(-)

This task depends upon

Comment by Alex Parker (BigBambi) - Friday, 22 May 2009, 19:11 GMT+2
Why do you want to remove the delete button for bookmarks?
Comment by Johannes Linke (Jaykay) - Friday, 22 May 2009, 19:37 GMT+2
because no other list has such a button. you will never now this button or button combination deletes an entry, until you find it out by accident or look at the button table in bookmarks in the manual. both cases are very unlikely. additionally the buttontable in the manual is redundant except the delete button, and it looks like another setting under the three of bookmarks.

i just noticed: the manual entry is redundant in any case, it's the same as 5.3.

note to self: i need to delete the entry there too.
Comment by Alex Parker (BigBambi) - Friday, 22 May 2009, 19:40 GMT+2
There are many other fucntions that you need to look in the manual to find out about. Surely that is the point of the manual. Are you saying we should remove everything that people aren't likely to guess without looking in the manual? I also don't see how no other lists have that functionality matters. Bookmarks are probably something you are more likely to delete than other things. I don't see how that is a reason for removing functionality. I agree that the rest of the button table in the manual is redundant, but that is no reason to remove functionality - remove the rest of the button table instead.
Comment by Johannes Linke (Jaykay) - Friday, 22 May 2009, 19:50 GMT+2
i guessed everything i need and some more things without the manual (except filetype colors :) ) for me the manual is something to look in when i don't understand something or don't know what a setting does. i guess very few people will search it for some hidden functionality.

there are four open patches about giving a free button (also the rec button) a new functionality. two of them are 2 and a half year old and one is rejected. you could think that some functionality of the rec button is not wanted.
Comment by Alex Parker (BigBambi) - Friday, 22 May 2009, 19:53 GMT+2
I still don't understand why this in any way justifies you wanting to remove this functionality - you think not many people know about it - this may be true. But I don't see how that is any justification for removing functionality. Many people don't know that many things, should we remove them?
Comment by Johannes Linke (Jaykay) - Friday, 22 May 2009, 19:58 GMT+2
i must admit that this is a good question :) maybe because people could wonder why rec doesn't delete files.

[irony] i have an idea: blowing in the microphone could move the selected track up in a playlist.[/irony] sorry :)

Loading...