Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10239 - USB storage write caching

Attached to Project: Rockbox
Opened by Frank Gevaerts (fg) - Sunday, 24 May 2009, 22:57 GMT+2
Last edited by Frank Gevaerts (fg) - Sunday, 05 June 2011, 13:17 GMT+2
Task Type Patches
Category Drivers
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Version 3.2
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

WARNING : this patch works for me, but it doesn't have any error checking and is therefore likely to eat data every now and then

This patch adds a write queue to improve write speeds by allowing fully overlapping usb and disk operations. This significantly improves write speed. In some cases it gets better than the OF.

Work needed before this is in any way ready to commit includes extending the SCSI handling to tell the host that we do write caching.
   write_queue.diff (15.5 KiB) 
 firmware/usbstack/usb_storage.c |  218 +++++++++++++++++++++++++++++-----------
 1 file changed, 159 insertions(+), 59 deletions(-)

This task depends upon

Closed by  Frank Gevaerts (fg)
Sunday, 05 June 2011, 13:17 GMT+2
Reason for closing:  Rejected
Additional comments about closing:  We won't do this
Comment by Frank Gevaerts (fg) - Monday, 25 May 2009, 22:06 GMT+2
This version adds error handling.

Unfortunately, disk errors aren't very visible. In linux they appear in dmesg, in windows they appear in the event log.
   write_queue_v2.diff (18.7 KiB) 
 firmware/usbstack/usb_storage.c |  375 +++++++++++++++++++++++++++++-----------
 1 file changed, 273 insertions(+), 102 deletions(-)

Comment by Rafaël Carré (funman) - Saturday, 26 June 2010, 00:51 GMT+2
Which player did you test this on?
Comment by Frank Gevaerts (fg) - Saturday, 26 June 2010, 01:18 GMT+2
This was either c200v1 or ipod video (or both)

Loading...