Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10253 - mkamsboot version 1.0

Attached to Project: Rockbox
Opened by Rafaël Carré (funman) - Thursday, 28 May 2009, 02:25 GMT+2
Last edited by Rafaël Carré (funman) - Thursday, 28 May 2009, 20:27 GMT+2
Task Type Patches
Category Bootloader
Status Closed
Assigned To Dave Chapman (linuxstb)
Player Type Another
Severity Low
Priority Normal
Reported Version Version 3.2
Due in Version Next release
Due Date Undecided
Percent Complete 100%
Private No

Details

cosmetics:
indent dualboot.S properly
remove trailing spaces

add some comments in dualboot.S
correct some comments in mkamsboot.c

move back extract_fw.c to utils/AMS/hacking

modify bin2c.c to produce only one pair of .c/.h files with several files embedded in it

move files needing to be built by an ARM cross compiler into dualboot/

commit produced .c/.h files (containing nrv2e_d8.S and dualboot.S built for Clip, Fuze, e200v2, c200v2, m200v4)

Build tested on linux i386, OSX intel, mingw cross compiler hosted on linux.

Produces the same bootloaders (bitexact) than current SVN.

Bump version to 1.0

Real README


I am waiting for approval from the mkamsboot author linuxstb ;)
   mkamsboot.diff (57.9 KiB) 
 b/rbutil/mkamsboot/Makefile            |   82 +------------
 b/rbutil/mkamsboot/README              |   59 +++++++++-
 a/rbutil/mkamsboot/bin2c.c             |  134 ----------------------
 a/rbutil/mkamsboot/dualboot.S          |  184 -------------------------------
 b/rbutil/mkamsboot/dualboot.c          |   99 ++++++++++++++++
 b/rbutil/mkamsboot/dualboot.h          |    8 +
 b/rbutil/mkamsboot/dualboot/Makefile   |   51 ++++++++
 b/rbutil/mkamsboot/dualboot/bin2c.c    |  129 +++++++++++++++++++++
 b/rbutil/mkamsboot/dualboot/dualboot.S |  187 +++++++++++++++++++++++++++++++
 b/rbutil/mkamsboot/dualboot/nrv2e_d8.S |  194 +++++++++++++++++++++++++++++++++
 a/rbutil/mkamsboot/extract_fw.c        |  129 ---------------------
 b/rbutil/mkamsboot/md5.c               |    2 
 b/rbutil/mkamsboot/mkamsboot.c         |   33 ++---
 a/rbutil/mkamsboot/nrv2e_d8.S          |  194 ---------------------------------
 b/utils/AMS/hacking/extract_fw.c       |  129 +++++++++++++++++++++
 15 files changed, 878 insertions(+), 736 deletions(-)

This task depends upon

Closed by  Rafaël Carré (funman)
Thursday, 28 May 2009, 20:27 GMT+2
Reason for closing:  Accepted
Comment by Rafaël Carré (funman) - Thursday, 28 May 2009, 13:24 GMT+2
I'll also merge the mkamsboot part of  FS#10185 
Comment by Rafaël Carré (funman) - Thursday, 28 May 2009, 15:25 GMT+2
Make mkamsboot a library (work by domonoky)

Limit lines to 80 characters.
Use a macro with variadic arguments for error cases in functions which might error.
Add detailed descriptions to functions exported by the library (in the header file)

EDIT : the whole patch didn't get in sorry
   mkamsboot.diff (50.9 KiB) 
 b/rbutil/mkamsboot/Makefile     |   85 -----
 b/rbutil/mkamsboot/README       |   59 ++++
 a/rbutil/mkamsboot/bin2c.c      |  134 ---------
 a/rbutil/mkamsboot/dualboot.S   |  184 ------------
 a/rbutil/mkamsboot/extract_fw.c |  129 ---------
 b/rbutil/mkamsboot/md5.c        |    2 
 b/rbutil/mkamsboot/mkamsboot.c  |  573 ++++++++++++++++++++--------------------
 a/rbutil/mkamsboot/nrv2e_d8.S   |  194 -------------
 8 files changed, 362 insertions(+), 998 deletions(-)

Comment by Rafaël Carré (funman) - Thursday, 28 May 2009, 19:02 GMT+2
Add Clipv2 , update README

Some more cosmetics in dualboot.S

Tested on my Clipv1, Clipv2, Fuzev1

linuxstb, on my side it's ok for commit; i would just like to know if you have comments (coding style for example)
   mkamsboot.diff (90 KiB) 
 b/rbutil/mkamsboot/Makefile            |   85 ----
 b/rbutil/mkamsboot/README              |   61 +++
 a/rbutil/mkamsboot/bin2c.c             |  134 -------
 a/rbutil/mkamsboot/dualboot.S          |  184 ----------
 b/rbutil/mkamsboot/dualboot.c          |  118 ++++++
 b/rbutil/mkamsboot/dualboot.h          |    9 
 b/rbutil/mkamsboot/dualboot/Makefile   |   54 ++
 b/rbutil/mkamsboot/dualboot/bin2c.c    |  131 +++++++
 b/rbutil/mkamsboot/dualboot/dualboot.S |  220 ++++++++++++
 b/rbutil/mkamsboot/dualboot/nrv2e_d8.S |  194 ++++++++++
 a/rbutil/mkamsboot/extract_fw.c        |  129 -------
 b/rbutil/mkamsboot/md5.c               |    2 
 b/rbutil/mkamsboot/mkamsboot.c         |  598 ++++++++++++++++-----------------
 b/rbutil/mkamsboot/mkamsboot.h         |  124 ++++++
 a/rbutil/mkamsboot/nrv2e_d8.S          |  194 ----------
 b/utils/AMS/hacking/extract_fw.c       |  132 +++++++
 16 files changed, 1362 insertions(+), 1007 deletions(-)

Loading...