Rockbox

Tasklist

FS#10263 - Pictureflow: start playback and integrate into databse's album note

Attached to Project: Rockbox
Opened by Thomas Martitz (kugel.) - Saturday, 30 May 2009, 17:49 GMT
Last edited by Thomas Martitz (kugel.) - Thursday, 22 December 2011, 15:38 GMT
Task Type Patches
Category Database
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Version 3.2
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

This patch adds pictureflow to the database's album note to start it.

Additionally it makes you able to start playback within pictureflow. It does so by creating a new playlist and starting it (overwriting the current one).

It doesn't feature the context menu though (i.e. no insert/queue actions). That can hopefully be added to pictureflow later.

It works pretty well for me. Tell me if it's committable (I hope it is :D )
This task depends upon

Closed by  Thomas Martitz (kugel.)
Thursday, 22 December 2011, 15:38 GMT
Reason for closing:  Out of Date
Additional comments about closing:  The playback contro and "go to wps from pf" parts are in SVN, but not the database part (and the solution here is not committable). A new task for that can be openend if wanted.
Comment by Thomas Martitz (kugel.) - Saturday, 30 May 2009, 18:09 GMT
Slight change in the fn offset logic, and also remove some debug statements. No functional change.
Comment by Thomas Martitz (kugel.) - Saturday, 30 May 2009, 19:02 GMT
Re-use the old playlist if one didn't leave the tracklist inbetween.
Comment by MichaelGiacomelli (saratoga) - Saturday, 30 May 2009, 22:32 GMT
Works nicely for me. Some obvious things I already mentioned on IRC:

Backlight time out settings are ignored (meaning quickly drained battery if you use this for playback)
No easy way to get to WPS (though I understand you have a fix for this)

Otherwise, very handy. Combined with JPEG support this works really well for me.
Comment by Thomas Martitz (kugel.) - Sunday, 31 May 2009, 01:27 GMT
This adds support to go to the WPS directly by adding a new exit code for plugins which is handled by the core.

Needs keymap for most targets, but it also adds a menu item since this may not be possible for every target using a key.
Comment by Thomas Martitz (kugel.) - Sunday, 31 May 2009, 14:58 GMT
Sync.
Comment by Taylore (trailblaze) - Sunday, 21 June 2009, 19:51 GMT
Im very sorry, but when patching it gives me 5 hunk errors.. May you please resync this please.. It looks like a huuuge fix to a big annoyance (not selecting and playing songs in pictureflow)... thanxs in advance :)
Comment by Thomas Martitz (kugel.) - Sunday, 21 June 2009, 21:03 GMT
The playback part is in SVN, you can actually start and control playback. This merely adds a half-baken database integration and the ability to jump to the wps from within pictureflow.

Loading...