Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10263 - Pictureflow: start playback and integrate into databse's album note

Attached to Project: Rockbox
Opened by Thomas Martitz (kugel.) - Saturday, 30 May 2009, 19:49 GMT+2
Last edited by Thomas Martitz (kugel.) - Thursday, 22 December 2011, 16:38 GMT+2
Task Type Patches
Category Database
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Version 3.2
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch adds pictureflow to the database's album note to start it.

Additionally it makes you able to start playback within pictureflow. It does so by creating a new playlist and starting it (overwriting the current one).

It doesn't feature the context menu though (i.e. no insert/queue actions). That can hopefully be added to pictureflow later.

It works pretty well for me. Tell me if it's committable (I hope it is :D )
   pictureflow-db+playback.patch (7.8 KiB) 
 apps/plugins/pictureflow/pictureflow.c |   63 +++++++++++++++++++++++++++------
 apps/plugin.c                          |    7 +++
 apps/plugin.h                          |    5 ++
 apps/tagtree.c                         |   35 ++++++++++++++++--
 4 files changed, 96 insertions(+), 14 deletions(-)

This task depends upon

Closed by  Thomas Martitz (kugel.)
Thursday, 22 December 2011, 16:38 GMT+2
Reason for closing:  Out of Date
Additional comments about closing:  The playback contro and "go to wps from pf" parts are in SVN, but not the database part (and the solution here is not committable). A new task for that can be openend if wanted.
Comment by Thomas Martitz (kugel.) - Saturday, 30 May 2009, 20:09 GMT+2
Slight change in the fn offset logic, and also remove some debug statements. No functional change.
   pictureflow-db+playback.patch (6.8 KiB) 
 apps/plugins/pictureflow/pictureflow.c |   60 ++++++++++++++++++++++++++++-----
 apps/plugin.c                          |    7 +++
 apps/plugin.h                          |    5 ++
 apps/tagtree.c                         |   33 +++++++++++++++++-
 4 files changed, 95 insertions(+), 10 deletions(-)

Comment by Thomas Martitz (kugel.) - Saturday, 30 May 2009, 21:02 GMT+2
Re-use the old playlist if one didn't leave the tracklist inbetween.
   pictureflow-db+playback-v2.patch (7 KiB) 
 apps/plugins/pictureflow/pictureflow.c |   65 ++++++++++++++++++++++++++++-----
 apps/plugin.c                          |    7 +++
 apps/plugin.h                          |    5 ++
 apps/tagtree.c                         |   33 ++++++++++++++++
 4 files changed, 100 insertions(+), 10 deletions(-)

Comment by MichaelGiacomelli (saratoga) - Sunday, 31 May 2009, 00:32 GMT+2
Works nicely for me. Some obvious things I already mentioned on IRC:

Backlight time out settings are ignored (meaning quickly drained battery if you use this for playback)
No easy way to get to WPS (though I understand you have a fix for this)

Otherwise, very handy. Combined with JPEG support this works really well for me.
Comment by Thomas Martitz (kugel.) - Sunday, 31 May 2009, 03:27 GMT+2
This adds support to go to the WPS directly by adding a new exit code for plugins which is handled by the core.

Needs keymap for most targets, but it also adds a menu item since this may not be possible for every target using a key.
   pictureflow-db+playback-v3.patch (15.5 KiB) 
 apps/plugins/pictureflow/pictureflow.c |  107 +++++++++++++++++++++++++--------
 apps/filetree.c                        |   32 ++++++---
 apps/plugin.c                          |   22 ++----
 apps/plugin.h                          |    6 +
 apps/tagtree.c                         |   39 +++++++++++-
 5 files changed, 158 insertions(+), 48 deletions(-)

Comment by Thomas Martitz (kugel.) - Sunday, 31 May 2009, 16:58 GMT+2
Sync.
   pictureflow-db+gotowps-v3b.patch (10.9 KiB) 
 apps/plugins/pictureflow/pictureflow.c |   42 ++++++++++++++++++++-------------
 apps/filetree.c                        |   32 +++++++++++++++++--------
 apps/plugin.c                          |   16 +++---------
 apps/plugin.h                          |    1 
 apps/tagtree.c                         |   39 +++++++++++++++++++++++++++++-
 5 files changed, 91 insertions(+), 39 deletions(-)

Comment by Taylore (trailblaze) - Sunday, 21 June 2009, 21:51 GMT+2
Im very sorry, but when patching it gives me 5 hunk errors.. May you please resync this please.. It looks like a huuuge fix to a big annoyance (not selecting and playing songs in pictureflow)... thanxs in advance :)
Comment by Thomas Martitz (kugel.) - Sunday, 21 June 2009, 23:03 GMT+2
The playback part is in SVN, you can actually start and control playback. This merely adds a half-baken database integration and the ability to jump to the wps from within pictureflow.

Loading...