Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10271 - automatically disable voice upon rockdoom startup

Attached to Project: Rockbox
Opened by Christian Beier (dontmind) - Wednesday, 03 June 2009, 15:29 GMT+2
Last edited by Karl Kurbjun (kkurbjun) - Friday, 18 December 2009, 05:26 GMT+2
Task Type Patches
Category Plugins
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

hi there,
attached is a simple fix to disable voice upon doom startup and re-enable it upon quitting rockdoom, in the fashion other plugins do it (e.g. mpegplayer).

tested succesfully on my ipod 5.5g.
   doom_disable_voice.patch (0.9 KiB) 
 apps/plugins/doom/rockdoom.c |   10 ++++++++++
 1 file changed, 10 insertions(+)

This task depends upon

Closed by  Karl Kurbjun (kkurbjun)
Friday, 18 December 2009, 05:26 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Thanks!
Comment by Rafaël Carré (funman) - Friday, 05 June 2009, 19:50 GMT+2
if( result == -1 )
+ {
+ rb->talk_disable(false);
return PLUGIN_OK; // Quit was selected
+ }
else
+ {
+ rb->talk_disable(false);
return PLUGIN_ERROR; // Missing base wads
+ }
}

You can just add rb->talk_disable(false); before if( result == -1 )
Comment by Christian Beier (dontmind) - Friday, 05 June 2009, 20:54 GMT+2
ahm..., right ;-)
   doom_disable_voice_r2.patch (0.8 KiB) 
 apps/plugins/doom/rockdoom.c |    5 +++++
 1 file changed, 5 insertions(+)

Comment by Christian Beier (dontmind) - Wednesday, 17 June 2009, 11:07 GMT+2
any chance of having this commited?
it's a simple fix for a simple issue...
Comment by Gman (Thecoolgman) - Wednesday, 17 June 2009, 12:15 GMT+2
I think it should be compiled
Comment by Gman (Thecoolgman) - Wednesday, 17 June 2009, 12:15 GMT+2
I mean commited :P

Loading...