Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10280 - Initial work on the Samsung YP-P2 port

Attached to Project: Rockbox
Opened by Alain Trinh (Soaa) - Friday, 05 June 2009, 15:53 GMT+2
Task Type Patches
Category Configuration
Status Unconfirmed
Assigned To No-one
Player Type Another
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Private No

Details

Hello, here's my current contribution to the Rockbox project: initial work on a port to the Samsung YP-P2. Right now, it's mostly just copied from the Cowon D2 port, but with some changes to reflect the P2's different LCD.

The LCD shows the picture undistorted, but it seems that the G channel is too strong. Perhaps this is due to the LCD being set to rgb666 mode, so it expects 6 bits from R and B, while Rockbox only gives 5 bits? I tried setting the LCD to rgb565 mode, but that only distorted the colors even more. In any case, suggestion for a fix would be great.
This task depends upon

Comment by Alain Trinh (Soaa) - Friday, 05 June 2009, 15:53 GMT+2
Oops, forgot to attach the diff.
   samsung_ypp2_port.diff (7.6 KiB) 
 tools/configure                              |   22 ++++++++++++++++++++++
 apps/plugins/lib/pluginlib_actions.c         |    4 ++++
 apps/SOURCES                                 |    2 ++
 firmware/export/config.h                     |    4 ++++
 firmware/SOURCES                             |   24 ++++++++++++++++++++++++
 firmware/target/arm/tcc780x/system-tcc780x.c |   26 +++++++++++++++++++++-----
 firmware/target/arm/wmcodec-telechips.c      |    2 +-
 firmware/target/arm/ata-nand-telechips.c     |    2 +-
 firmware/target/arm/pcm-telechips.c          |    2 +-
 9 files changed, 80 insertions(+), 8 deletions(-)

Comment by Alain Trinh (Soaa) - Friday, 05 June 2009, 16:04 GMT+2
Oops. Forgot to svn add the new files. This one should work.
   samsung_ypp2_port.diff (50.1 KiB) 
 tools/configure                                     |   22 +
 apps/plugins/lib/pluginlib_actions.c                |    4 
 apps/SOURCES                                        |    2 
 firmware/export/config.h                            |    4 
 firmware/export/config-ypp2.h                       |  167 +++++++++
 firmware/SOURCES                                    |   24 +
 firmware/target/arm/tcc780x/system-tcc780x.c        |   26 +
 firmware/target/arm/tcc780x/ypp2/backlight-ypp2.c   |   51 ++
 firmware/target/arm/tcc780x/ypp2/adc-target.h       |   28 +
 firmware/target/arm/tcc780x/ypp2/backlight-target.h |   29 +
 firmware/target/arm/tcc780x/ypp2/usb-ypp2.c         |   45 ++
 firmware/target/arm/tcc780x/ypp2/button-ypp2.c      |  195 ++++++++++
 firmware/target/arm/tcc780x/ypp2/power-ypp2.c       |  148 ++++++++
 firmware/target/arm/tcc780x/ypp2/button-target.h    |   69 +++
 firmware/target/arm/tcc780x/ypp2/i2c-target.h       |   39 ++
 firmware/target/arm/tcc780x/ypp2/powermgmt-ypp2.c   |   84 ++++
 firmware/target/arm/tcc780x/ypp2/audio-ypp2.c       |   96 +++++
 firmware/target/arm/tcc780x/ypp2/lcd-ypp2.c         |  364 ++++++++++++++++++++
 firmware/target/arm/wmcodec-telechips.c             |    2 
 firmware/target/arm/ata-nand-telechips.c            |    2 
 firmware/target/arm/pcm-telechips.c                 |    2 
 21 files changed, 1395 insertions(+), 8 deletions(-)

Comment by Alain Trinh (Soaa) - Saturday, 06 June 2009, 04:35 GMT+2
A new diff with fixed timings.
   samsung_ypp2_port.diff (50.1 KiB) 
 tools/configure                                     |   22 +
 apps/plugins/lib/pluginlib_actions.c                |    4 
 apps/SOURCES                                        |    2 
 firmware/export/config.h                            |    4 
 firmware/export/config-ypp2.h                       |  167 +++++++++
 firmware/SOURCES                                    |   24 +
 firmware/target/arm/tcc780x/system-tcc780x.c        |   26 +
 firmware/target/arm/tcc780x/ypp2/backlight-ypp2.c   |   51 ++
 firmware/target/arm/tcc780x/ypp2/adc-target.h       |   28 +
 firmware/target/arm/tcc780x/ypp2/backlight-target.h |   29 +
 firmware/target/arm/tcc780x/ypp2/usb-ypp2.c         |   45 ++
 firmware/target/arm/tcc780x/ypp2/button-ypp2.c      |  195 ++++++++++
 firmware/target/arm/tcc780x/ypp2/power-ypp2.c       |  148 ++++++++
 firmware/target/arm/tcc780x/ypp2/button-target.h    |   69 +++
 firmware/target/arm/tcc780x/ypp2/i2c-target.h       |   39 ++
 firmware/target/arm/tcc780x/ypp2/powermgmt-ypp2.c   |   84 ++++
 firmware/target/arm/tcc780x/ypp2/audio-ypp2.c       |   96 +++++
 firmware/target/arm/tcc780x/ypp2/lcd-ypp2.c         |  364 ++++++++++++++++++++
 firmware/target/arm/wmcodec-telechips.c             |    2 
 firmware/target/arm/ata-nand-telechips.c            |    2 
 firmware/target/arm/pcm-telechips.c                 |    2 
 21 files changed, 1395 insertions(+), 8 deletions(-)

Comment by Alain Trinh (Soaa) - Saturday, 06 June 2009, 05:31 GMT+2
And a new patch to add the missing keymap file.
   samsung_ypp2_port.diff (10.2 KiB) 
 plugins/lib/pluginlib_actions.c |    4 
 SOURCES                         |    2 
 keymaps/keymap-ypp2.c           |  204 ++++++++++++++++++++++++++++++++++++++++
 3 files changed, 210 insertions(+)

Comment by Alain Trinh (Soaa) - Saturday, 06 June 2009, 05:33 GMT+2
Shoot! Ignore the last one. This one's right.
   samsung_ypp2_port.diff (58.4 KiB) 
 tools/configure                                     |   22 +
 apps/plugins/lib/pluginlib_actions.c                |    4 
 apps/SOURCES                                        |    2 
 apps/keymaps/keymap-ypp2.c                          |  204 +++++++++++
 firmware/export/config.h                            |    4 
 firmware/export/config-ypp2.h                       |  167 +++++++++
 firmware/SOURCES                                    |   24 +
 firmware/target/arm/tcc780x/system-tcc780x.c        |   26 +
 firmware/target/arm/tcc780x/ypp2/backlight-ypp2.c   |   51 ++
 firmware/target/arm/tcc780x/ypp2/adc-target.h       |   28 +
 firmware/target/arm/tcc780x/ypp2/backlight-target.h |   29 +
 firmware/target/arm/tcc780x/ypp2/usb-ypp2.c         |   45 ++
 firmware/target/arm/tcc780x/ypp2/button-ypp2.c      |  195 ++++++++++
 firmware/target/arm/tcc780x/ypp2/power-ypp2.c       |  148 ++++++++
 firmware/target/arm/tcc780x/ypp2/button-target.h    |   69 +++
 firmware/target/arm/tcc780x/ypp2/i2c-target.h       |   39 ++
 firmware/target/arm/tcc780x/ypp2/powermgmt-ypp2.c   |   84 ++++
 firmware/target/arm/tcc780x/ypp2/audio-ypp2.c       |   96 +++++
 firmware/target/arm/tcc780x/ypp2/lcd-ypp2.c         |  364 ++++++++++++++++++++
 firmware/target/arm/wmcodec-telechips.c             |    2 
 firmware/target/arm/ata-nand-telechips.c            |    2 
 firmware/target/arm/pcm-telechips.c                 |    2 
 22 files changed, 1599 insertions(+), 8 deletions(-)

Comment by AntiXpucT (AntiXpucT) - Friday, 12 March 2010, 18:43 GMT+2
Hi there. Is it any progress in this way? ;) And how i can flash this firmware on YP-P2? ;)
//w.b.r.
Comment by AntiXpucT (AntiXpucT) - Saturday, 13 March 2010, 02:10 GMT+2
Here is working patch for current sources tree (working with 25139)
   ypp2.patch (58.9 KiB) 
 tools/configure                                     |   22 +
 apps/plugins/lib/pluginlib_actions.c                |    4 
 apps/SOURCES                                        |    2 
 apps/keymaps/keymap-ypp2.c                          |  204 +++++++++++
 firmware/export/config.h                            |    4 
 firmware/export/config/ypp2.h                       |  167 +++++++++
 firmware/SOURCES                                    |   23 +
 firmware/target/arm/tcc780x/system-tcc780x.c        |   26 +
 firmware/target/arm/tcc780x/ypp2/backlight-ypp2.c   |   51 ++
 firmware/target/arm/tcc780x/ypp2/adc-target.h       |   28 +
 firmware/target/arm/tcc780x/ypp2/backlight-target.h |   29 +
 firmware/target/arm/tcc780x/ypp2/usb-ypp2.c         |   45 ++
 firmware/target/arm/tcc780x/ypp2/button-ypp2.c      |  195 ++++++++++
 firmware/target/arm/tcc780x/ypp2/power-ypp2.c       |  148 ++++++++
 firmware/target/arm/tcc780x/ypp2/button-target.h    |   69 +++
 firmware/target/arm/tcc780x/ypp2/i2c-target.h       |   39 ++
 firmware/target/arm/tcc780x/ypp2/powermgmt-ypp2.c   |   84 ++++
 firmware/target/arm/tcc780x/ypp2/audio-ypp2.c       |   96 +++++
 firmware/target/arm/tcc780x/ypp2/lcd-ypp2.c         |  364 ++++++++++++++++++++
 firmware/target/arm/wmcodec-telechips.c             |    2 
 firmware/target/arm/ata-nand-telechips.c            |    2 
 firmware/target/arm/pcm-telechips.c                 |    2 
 22 files changed, 1598 insertions(+), 8 deletions(-)

Comment by roman (roma342) - Thursday, 19 August 2010, 15:06 GMT+2
Children and when this updating will be already ready? Simply I незнаю how to establish prompt please!

Loading...