Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10281 - remove viewport menu from star

Attached to Project: Rockbox
Opened by Johannes Schwarz (Ubuntuxer) - Friday, 05 June 2009, 18:29 GMT+2
Last edited by Johannes Schwarz (Ubuntuxer) - Saturday, 20 June 2009, 23:51 GMT+2
Task Type Bugs
Category Plugins
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Version 3.2
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

The following patch removes the use of viewport from the star menu. The viewport blankets the status bar on top, but doesn't work during scrolling, so it looks strange and doesn't fit to other plugins.
Additionally the patch removes useless button macros in the code.
   star.diff (6 KiB) 
 apps/plugins/star.c |   44 ++------------------------------------------
 1 file changed, 2 insertions(+), 42 deletions(-)

This task depends upon

Closed by  Johannes Schwarz (Ubuntuxer)
Saturday, 20 June 2009, 23:51 GMT+2
Reason for closing:  Accepted
Comment by Thomas Martitz (kugel.) - Friday, 19 June 2009, 21:45 GMT+2
This isn't a fix. It just hides the problem of the statusbar coming up even though it should be hidden.
Comment by Johannes Schwarz (Ubuntuxer) - Saturday, 20 June 2009, 09:44 GMT+2
I know it doesn't fix the actual problem, but in my opinion the plugin star shouldn't hide the statusbar, because the plugins' menus should look equal. I don't see the sense of hiding the statusbar.

Loading...