Rockbox

Tasklist

FS#10290 - Sansa AMS language fixes

Attached to Project: Rockbox
Opened by Bertrik Sikken (bertrik) - Sunday, 07 June 2009, 07:56 GMT
Last edited by Rafaël Carré (funman) - Tuesday, 30 June 2009, 21:15 GMT
Task Type Patches
Category Language
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Version 3.2
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Attached file fixes some language/key issues for the AMS Sansas:
* any references to c200 are changed into c200* so they apply to the c200v2 too
* references to the SELECT button (instead of PLAY) now also apply to fuze* and clip* (LANG_CONFIRM_WITH_BUTTON and LANG_TIME_SET_BUTTON)

Open issues:
* the sansa m200v4 (or m200) is not mentioned at all yet in the language file. Should it be added?
This task depends upon

Closed by  Rafaël Carré (funman)
Tuesday, 30 June 2009, 21:15 GMT
Reason for closing:  Accepted
Additional comments about closing:  closing since there were no m200 patch attached - committed in r21579
Comment by Rafaël Carré (funman) - Monday, 08 June 2009, 00:17 GMT
that would be a work for domonoky or another m200v4 owner (m200 support still lacks storage support from what I read, but I didn't verify)
Comment by Bertrik Sikken (bertrik) - Wednesday, 10 June 2009, 12:37 GMT
BTW, these changes should be made to all languages (not just english), tools/langtool.pl can probably help with that.
Comment by Bertrik Sikken (bertrik) - Wednesday, 24 June 2009, 15:36 GMT
rasher just committed the c200 -> c200* part of this in svn r21490.
Comment by Rafaël Carré (funman) - Wednesday, 24 June 2009, 16:19 GMT
hillshum spoke about LANG_CONFIRM_WITH_BUTTON on irc

after this is changed it would become a m200 only bug i think
Comment by Jonas Häggqvist (rasher) - Wednesday, 24 June 2009, 16:21 GMT
Please do these changes for all languages. tools/langtool.pl can automate this process. Sorry for messing up the work by committing the c200 > c200* change.
Comment by Bertrik Sikken (bertrik) - Thursday, 25 June 2009, 15:32 GMT
rasher, it was already my intention to use langtool, see my comment from Wednesday, 10 June 2009, 13:37 GMT+1
And don't worry about messing up, it was already messed up by svn r21346 (which *did* do a change to english.lang only).

Please note that the original patch uses clip* instead of just clip (to include the clipv2) and fuze* instead of just fuze (to include the fuzev2)
Comment by Jonas Häggqvist (rasher) - Thursday, 25 June 2009, 15:38 GMT
Yeah, I saw that you'd already posted that, also. Sorry again.

Maybe it's smarter to attach a series of langtool commandlines here, rather than a patch?
Comment by Hilton Shumway (HIllshum) - Friday, 26 June 2009, 03:16 GMT
here's the langtool commands for changing LANG_CONFIRM_WITH_BUTTON and LANG_TIME_SET_BUTTON, and changing all "fuze" and "clip" to "fuze*" and "clip*"
Comment by Hilton Shumway (HIllshum) - Tuesday, 30 June 2009, 17:15 GMT
This version uses a better way of replacing "fuze" and "clip" with "fuze*" and "clip*"
Comment by Hilton Shumway (HIllshum) - Tuesday, 30 June 2009, 18:14 GMT
Because there's no need to deal with changing the clip, it's taken out (thank to rasher for pointing that out).
Comment by Hilton Shumway (HIllshum) - Tuesday, 30 June 2009, 18:33 GMT
Okay, here's the ones I found after reading through english.lang. LANG_DISK_NAME_MMC needs the Fuze added, LANG_TIME_SET_REVERT and LANG_BUILDING_DATABASE may need to be changed as well (depending on what keys are actually uses). LANG_DISK_FULL and LANG_OFF_ABORT are recording-only so any players that can record (currently none) need that.
Comment by Hilton Shumway (HIllshum) - Tuesday, 30 June 2009, 20:05 GMT
This version adds the aforementioned lang entries, excepting the recording dependent ones. I'm pretty sure this is all of the entries we need to change
Comment by Hilton Shumway (HIllshum) - Tuesday, 30 June 2009, 20:32 GMT
Got a string wrong. Fixed

Loading...