Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10306 - Sansa Fuze&e200v2: An attempt to fix the buttonlight

Attached to Project: Rockbox
Opened by Thomas Martitz (kugel.) - Tuesday, 09 June 2009, 16:33 GMT+2
Last edited by Rafaël Carré (funman) - Friday, 19 June 2009, 00:33 GMT+2
Task Type Patches
Category Drivers
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Version 3.2
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This hopefully fixes the buttonlight for the mentioned targets.

It's annoying how much hackery in the SD driver is needed for it to work, but I think I got it.

Please test and report if you notice weirdnesses.
   as3525.vc.diff (3 KiB)
 firmware/target/arm/as3525/backlight-e200v2-fuze.c |   10 ++++++++
 firmware/target/arm/as3525/ata_sd_as3525.c         |   26 +++++++++++++++------
 2 files changed, 29 insertions(+), 7 deletions(-)

This task depends upon

Closed by  Rafaël Carré (funman)
Friday, 19 June 2009, 00:33 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  r21340
Comment by Jack Halpin (FlynDice) - Tuesday, 09 June 2009, 22:55 GMT+2
seems to work just fine here e280v2. No buttonlight on disk access. Aren't you going to miss it a just a little bit though... ;)
Comment by Rafaël Carré (funman) - Tuesday, 09 June 2009, 23:28 GMT+2
works fine on fuze, and yeah i'm gonna miss it :)
Comment by Matt M (Chesteta) - Wednesday, 10 June 2009, 01:01 GMT+2
haha i wont miss it when its night time ;P your eyes get used to the dark and then BAM BRIGHT blue buttonlight hits you in the eyes...
Comment by Matt M (Chesteta) - Wednesday, 10 June 2009, 03:08 GMT+2
haha i wont miss it when its night time ;P your eyes get used to the dark and then BAM BRIGHT blue buttonlight hits you in the eyes...
Comment by Matt M (Chesteta) - Wednesday, 10 June 2009, 03:09 GMT+2
i refreshed the page and it re-posted :/ sorry
Comment by Hilton Shumway (HIllshum) - Wednesday, 10 June 2009, 03:23 GMT+2
The ideal would be to give the choice of having the light flash. Could the SD driver hackery be disabled or would we need to make the light flash the "right" way?
Comment by Dustin Skoracki (sko) - Wednesday, 10 June 2009, 08:02 GMT+2
Works good while playing music, but I had one little light flash (less than a second) while playing a movie (e250v2).
Comment by Rafaël Carré (funman) - Thursday, 18 June 2009, 20:27 GMT+2
can this be committed ?

I think it will be needed for c200v2 as well
Comment by Michael Chicoine (mc2739) - Friday, 19 June 2009, 00:00 GMT+2
Please do. It works well for me.

Loading...