Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10330 - pluginlib: xlcd_scroll_* functions should clear screen for high scroll count

Attached to Project: Rockbox
Opened by Torne Wuff (torne) - Sunday, 14 June 2009, 02:44 GMT+2
Last edited by Torne Wuff (torne) - Friday, 16 October 2009, 22:18 GMT+2
Task Type Patches
Category Plugins
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

The xlcd_scroll_* functions in pluginlib check if the pixel count to scroll is more than the relevant screen dimension, and if so they do nothing. This seems wrong: if you ask to scroll up by LCD_HEIGHT - 1 then it clears all the lines of the screen except the top, so scrolling by LCD_HEIGHT or more should logically just clear the entire screen.

Attached patch makes them call lcd_clear_display() instead of doing nothing.

The greylib scroll functions have the same bug, but the fix is not so trivial, and I've not delved into how greylib works..
   xlcd_scroll_fix.diff (1.9 KiB) 
 apps/plugins/lib/xlcd_scroll.c |   24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

This task depends upon

Closed by  Torne Wuff (torne)
Friday, 16 October 2009, 22:18 GMT+2
Reason for closing:  Fixed
Additional comments about closing:  Submitted in r23211
Comment by Torne Wuff (torne) - Friday, 16 October 2009, 21:53 GMT+2
Updated to include greylib, and to include the new xlcd packing mode.
   pluginlib_scroll_fix.diff (5 KiB) 
 apps/plugins/lib/grey_scroll.c |   24 ++++++++++++++++++++++++
 apps/plugins/lib/xlcd_scroll.c |   36 ++++++++++++++++++++++++++++++++++++
 2 files changed, 60 insertions(+)

Loading...