Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10336 - Simplify list voicing to speak last/first entry in lists better

Attached to Project: Rockbox
Opened by Steve Bavin (pondlife) - Monday, 15 June 2009, 11:19 GMT+2
Last edited by Steve Bavin (pondlife) - Tuesday, 15 June 2010, 09:09 GMT+2
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Here's a first attempt to simplify the voice handling in lists.

It moves all setting of gui_list.selected_item into a single routine (apart from initialisation) rather than trying to track at a button level.

Apart from simplifying, the main intended change is that when a user holds DOWN (or UP), the last (or first) item in a list will now be spoken without any need to release the button.

This probably breaks something (scrollwheels?), but please give it a go and report back.
   talking_list_rework.patch (19.2 KiB) 
 apps/gui/list.c |  243 ++++++++++++++++++++++++++++----------------------------
 1 file changed, 122 insertions(+), 121 deletions(-)

This task depends upon

Closed by  Steve Bavin (pondlife)
Tuesday, 15 June 2010, 09:09 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Committed as r26853.
Comment by Steve Bavin (pondlife) - Monday, 15 June 2009, 12:00 GMT+2
Remove debug.h.
   talking_list_rework-090615.patch (18.7 KiB) 
 apps/gui/list.c |  247 ++++++++++++++++++++++++++++----------------------------
 1 file changed, 125 insertions(+), 122 deletions(-)

Comment by alex wallis (alexwallis646) - Monday, 15 June 2009, 13:48 GMT+2
I installed this patch into a build, and unfortunately It doesn't seem to work.
when holding up or down, I get no speech feedback when the end or beginning of list is reached.
I didn't completely replace my rockbox folder, I simply unzipped a new archive and said yes to replacing all the files, could that have made a difference?
Also, just a suggestion, but when this patch begins to announce things once the top or bottom of a list is reached, could it be made so that releasing the joystick or means of navigation on the player stops the speech? this means that you would reduce the amount of unnecessary information from the speech. Because the very triggering of the speech would tell you you had arrived where you wanted to be, so you don't need to hear the hole item you are on.
Comment by Steve Bavin (pondlife) - Monday, 15 June 2009, 14:23 GMT+2
Hi Alex, which target are you using? I've only tried it on the sim, and then only in the main menu. In this situation, an unpatched build won't speak the last entry until you release the DOWN button, but with this patch it should speak it regardless (i.e. shortly after you reach the entry).

Also, make sure you don't have any other patches applied when testing.

Comment by alex wallis (alexwallis646) - Monday, 15 June 2009, 14:38 GMT+2
this is on the h140 target.
I would prefer to test on sim, however I can't get my sim to talk to me. even if I have a voice file in the right folder, I don't get any form of voice when I start the sim.
I would like to get my sim talking as I guess its not healthy for my target to keep being used for fresh builds do you have any thoughts what the problem might be?
I am pressing enter on the executable to start the sim, and it appears to start I just get no voice.
Comment by Steve Bavin (pondlife) - Monday, 15 June 2009, 15:28 GMT+2
You need to build a voice file for the simulator, it's not able to use the same file as for the target. RBUtil works, but I know it's not fully accessible.

Theattached patch should fix the problem, but it also queues the voice clips and speaks too much, so definitely a work in progress....
   talking_list_rework-090615a.patch (18.7 KiB) 
 apps/gui/list.c |  245 ++++++++++++++++++++++++++++----------------------------
 1 file changed, 123 insertions(+), 122 deletions(-)

Comment by alex wallis (alexwallis646) - Monday, 15 June 2009, 16:36 GMT+2
thanks for the info about the simulator. That is where I have been going wrong then as I was trying to use a target voice file for the simulator.
I know this is going off topic for the patch, but why exactly does the simulator not use the same voice file as target and vise versa? given that the simulator is designed as closely as possible to simulate an actual target.
I don't think the wiki for the simulator says that you can't use a target voice file as I looked there when I had problems getting it talking.
I will build a voice file for the simulator and see if it will talk then. I presume I just select advanced, then voice and then enter make voice as normal?
Getting back to the topic of the patch I didn't fully understand your last comment what does this latest patch fix? it not working on target?
Comment by alex wallis (alexwallis646) - Wednesday, 17 June 2009, 13:15 GMT+2
Good news, I just compiled a fresh build, and your latest patch works fine on target.
However, I think what would be good would be if your browsing in the file browser particularly if you are using spelling of file or folder names would be that if you scroll to the beginning or end of a list by holding up or down, as soon as you release the joystick spelling of the file or folder name is interrupted. I think this would be good because otherwise you have to listen to a huge long name. Whereas if releasing the joystick cut the speech off it means you don't have to put up with this information.
That is the only problem I have with this patch though. If my above idea could be introduced I would be quite happy to use this instead of Stephanes beep patch.
Comment by Steve Bavin (pondlife) - Wednesday, 29 July 2009, 18:51 GMT+2
As requested, here's a resync. I've not tested this at all, beyond compiling, so please check it works the same and report back!
   talking_list_rework-090729.patch (15.7 KiB) 
 apps/gui/list.c |  203 ++++++++++++++++++++++++++++----------------------------
 1 file changed, 102 insertions(+), 101 deletions(-)

Comment by Steve Bavin (pondlife) - Wednesday, 29 July 2009, 19:10 GMT+2
Same again without the variable name and whitespace changes. (The variable names should still be made consistent by a seperate commit, IMHO.)
   talking_list_rework-090729a.patch (7.3 KiB) 
 apps/gui/list.c |  108 ++++++++++++++++++++++++++++----------------------------
 1 file changed, 55 insertions(+), 53 deletions(-)

Comment by Steve Bavin (pondlife) - Monday, 07 June 2010, 11:42 GMT+2
Resync! I still don't have a target device, but this seems ok on sim.

Please can I request testing on a device by a voice user. Let me know if you'd like me to compile a build for you. In particular I'd like playlist/bookmark stuff to be checked; I can't make the SVN code speak but there appears to be provision in there, which I hope not to have changed.
   talking_list_rework-100607.patch (7 KiB) 
 apps/gui/list.c |  107 ++++++++++++++++++++++++++------------------------------
 1 file changed, 51 insertions(+), 56 deletions(-)

Comment by Steve Bavin (pondlife) - Monday, 07 June 2010, 16:49 GMT+2
Fix a problem scrolling in non-selector lists.
   talking_list_rework-100607a.patch (5.9 KiB) 
 apps/gui/list.c |   96 ++++++++++++++++++++++++++------------------------------
 1 file changed, 46 insertions(+), 50 deletions(-)

Loading...