Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10341 - Timestretch: speed-only bugged if you didn't use speed-corrected pitch before

Attached to Project: Rockbox
Opened by Thomas Martitz (kugel.) - Tuesday, 16 June 2009, 03:08 GMT+2
Last edited by Steve Bavin (pondlife) - Wednesday, 17 June 2009, 13:23 GMT+2
Task Type Bugs
Category Music playback
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

You enabled timestretch and when into the pitchscreen -> timestretch mode.

If you didn't use speed corrected pitch before, speed-only change will not work. It creates silence on my e200, the song elapsed time goes really fast and sometimes the next track info is messed up.

Observed on r21305 and r21304.
This task depends upon

Closed by  Steve Bavin (pondlife)
Wednesday, 17 June 2009, 13:23 GMT+2
Reason for closing:  Fixed
Additional comments about closing:  markun reports that this fixes the same issue on his Beast - so hopefully it's sorted out now.
Comment by Steve Bavin (pondlife) - Tuesday, 16 June 2009, 09:11 GMT+2
I can't repro this in r21309 - although if you start any kind of timestretch shortly after boot (while dircache scanning is ongoing) then there might be long gaps as the buffering is overwhelmed.
Comment by Thomas Martitz (kugel.) - Tuesday, 16 June 2009, 09:31 GMT+2
I updated an can still reproduce it. Even in the sim, there the behavior is a bit different though (the console output says "sdl_audio_callback: No Data." and then it skips the track).
Comment by Steve Bavin (pondlife) - Tuesday, 16 June 2009, 10:23 GMT+2
I get the "sdl_audio_callback: No Data." - that's normal for a buffer underrun, but it should pause awhile then continue, not skip tracks.

Could youi maybe attach your configuration?
Comment by Steve Bavin (pondlife) - Tuesday, 16 June 2009, 18:24 GMT+2
Does this help at all?
   10341_fix_attempt.patch (2.2 KiB) 
 apps/dsp.c |   49 ++++++++++++++++++++-----------------------------
 1 file changed, 20 insertions(+), 29 deletions(-)

Loading...