Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10343 - Resume playback even if it reached the end and stopped

Attached to Project: Rockbox
Opened by Mikael Magnusson (mikaelh) - Tuesday, 16 June 2009, 23:29 GMT+2
Task Type Patches
Category Playlists
Status Requires testing
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Private No

Details

If playback finished with repeat off, let you resume the last playlist by pressing play or selecting the 'resume playlist' option in the main menu instead of showing the dreaded "nothing to resume" splash.
As a side effect it will also resume if you restart the player and have it set to resume which you would probably want to fix. I didn't update to the latest revision (i have 21295) that has jdgordon's namechange thing so it will probably show 'nothing to resume' if you apply it but still actually resume.
This task depends upon

Comment by Mikael Magnusson (mikaelh) - Wednesday, 17 June 2009, 10:10 GMT+2
leaving a box empty apparently empties the attachment field for you
   0001-Resume-last-playlist-even-if-we-reached-the-... (1.3 KiB) 
 b/apps/root_menu.c |   15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

Comment by Alexander Levin (fml2) - Saturday, 20 June 2009, 18:49 GMT+2
I'm very much in favor of this. I have not tried the patch but would welcome the described change in the behaviour.
Comment by Rosso Maltese (asettico) - Saturday, 05 September 2009, 18:38 GMT+2
I'm using the patch to great satisfaction.
I wish that the playback doesn't automatically restart if the play list reached the end before switch the DAP off, but only when press the play button, as if I pressed Long Play and then Play.
Unfortunately, I haven't the necessary knowledge about the software architecture.
Comment by Rosso Maltese (asettico) - Saturday, 17 October 2009, 10:30 GMT+2
Sync to 23221.

What about my previous request? ;-)
   playlists-10343resume-last-playlist_v1.0.patch (1 KiB) 
 apps/root_menu.c |   15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

Comment by Frank Gevaerts (fg) - Monday, 29 March 2010, 23:37 GMT+2
So this would basically make the player ignore the repeat setting in some circumstances? I'm not sure if I like that idea
Comment by Rosso Maltese (asettico) - Tuesday, 30 March 2010, 09:37 GMT+2
I understood the meaning of the patch as a way to avoid that a dynamic play list will be forgotten when finished.
My request is independent from any repeat setting.
Comment by Alexander Levin (fml2) - Tuesday, 30 March 2010, 09:40 GMT+2
@Frank: Hrm... If it's really the case then I'll look more closely into this. What I want to have is that if the playback reaches the end and the playback stops (because there is no repeat) it should be possible to resume playback (restart the playlist) by pressing PLAY.
Comment by Mike Holden (mikeholden) - Tuesday, 30 March 2010, 12:34 GMT+2
So if I press PLAY after playback has completed, it starts over again?

Hate the idea, and wouldn't want this implemented without something so I can turn it off. I generally press PLAY to resume when I turn my player on, often without remembering exactly what I was listening to when I switched it off. I don't want to waste time (and battery) resuming something that has already finished.
Comment by Alexander Levin (fml2) - Tuesday, 30 March 2010, 21:15 GMT+2
On the mailing list it has two ways to resume a finished playlist have been advised: http://www.rockbox.org/mail/archive//rockbox-dev-archive-2010-03/0161.shtml , http://www.rockbox.org/mail/archive//rockbox-dev-archive-2010-03/0158.shtml

If they work that would do what I need and i wouldn't need the feature implemented by this patch anymore.
Comment by sideral (sideral) - Monday, 15 November 2010, 15:30 GMT+2
I second the original request. There should be a simple way to inspect a finished playlist once again and play (parts of) it again if desired. It does not have to be automatic in any way, so it can stay out of the way of users who rely on previously listened tracks not being repeated automatically.

The forum postings linked to in the previous comment do not explain how this can be achieved today, so I gather that this feature indeed seems to be missing.
Comment by sideral (sideral) - Tuesday, 05 July 2011, 15:28 GMT+2
OK, I now have found Playlists → View Current Playlist, which allows inspecting a playlist after it has completed playback (as long as the player has not been rebooted –  FS#11644  would fix that). Not exactly easily discoverable, but it's there. :-)

Here's a proposal: Instead of the “Nothing to resume” message, how about a “Playlist completed” splash, followed by automatically firing up the playlist editor with the current playlist (if possible)? For bonus points, the screen heading would be “Completed playlist” instead of just “Playlist”.

This would allow users to restart playback immediately if that was their intention, and also would prevent automatically starting playback of old content when selecting Resume (or when Resume Playback has been selected as the start screen after boot).
Comment by Rosso Maltese (asettico) - Tuesday, 05 July 2011, 15:47 GMT+2
Really +1 for me! :-D
Comment by Rosso Maltese (asettico) - Friday, 22 July 2011, 14:45 GMT+2
Sync to r30189.
   10343-playlists-Resume_playback_even_if_it_reache... (1 KiB) 
 apps/root_menu.c |   15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

Loading...