Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10391 - Center on loaded theme

Attached to Project: Rockbox
Opened by Jonas Häggqvist (rasher) - Sunday, 28 June 2009, 18:43 GMT+2
Last edited by Jonas Häggqvist (rasher) - Thursday, 16 July 2009, 18:52 GMT+2
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Version 3.3
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch will center on the most recently loaded theme when browsing themes. If the user has changed theme related settings, this will not be completely accurate. In my opinion, this will very very rarely lead to confusion, since the user will know that he's changed some settings. It could even be seen as a quick way to "reset" theme settings to the one he started out with.

It also changes "Browse Theme Files" to simply "Theme", to make it feel more like a setting.
   center_on_loaded_theme_FS#10391_v1.diff (2.4 KiB) 
 apps/tree.c            |   12 ++++++++++++
 apps/lang/english.lang |    6 +++---
 apps/settings.h        |    1 +
 apps/filetree.c        |    6 ++++++
 4 files changed, 22 insertions(+), 3 deletions(-)

Closed by  Jonas Häggqvist (rasher)
Thursday, 16 July 2009, 18:52 GMT+2
Reason for closing:  Rejected
Additional comments about closing:  Unwanted behaviour.
Comment by Gman (Thecoolgman) - Thursday, 16 July 2009, 03:37 GMT+2
Needs resync
Comment by Jonathan Gordon (jdgordon) - Thursday, 16 July 2009, 03:43 GMT+2
Gman, this is the third patch youve posted that to.. stop it.. if the patch author cares about the patch he will resync it.. if he doesnt then you should take control and sync it yourself (or find someone who can help you)

Loading...