- Status Closed
- Percent Complete
- Task Type Patches
- Category Plugins
- Assigned To No-one
- Operating System All players
- Severity Low
- Priority Very Low
- Reported Version Version 3.3
- Due in Version Undecided
-
Due Date
Undecided
- Votes
- Private
FS#10403 - Random Folder Advance playlist generation
This patch adds a “Play Shuffled” menu item to random_folder_advance_config, which adds all configured configured directories to the current playlist in random order (tracks within a directory remain in “normal” order)
It somewhat works:
- Sometimes a proper playlist control file is generated, and “resume playback” will start this big random-folder playlist
- Sometimes the player freezes after exiting the plugin
- Sometimes “resume playback” complains about a corrupt playlist control file
- In the cases where it works, the previous playlist isn’t always cleared, and playback doesn’t start at the beginning.
Further help is welcome :)
Closed by fg
2009-07-01 17:00
Reason for closing: Accepted
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407
2009-07-01 17:00
Reason for closing: Accepted
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407
committed as r21594
Loading...
Available keyboard shortcuts
- Alt + ⇧ Shift + l Login Dialog / Logout
- Alt + ⇧ Shift + a Add new task
- Alt + ⇧ Shift + m My searches
- Alt + ⇧ Shift + t focus taskid search
Tasklist
- o open selected task
- j move cursor down
- k move cursor up
Task Details
- n Next task
- p Previous task
- Alt + ⇧ Shift + e ↵ Enter Edit this task
- Alt + ⇧ Shift + w watch task
- Alt + ⇧ Shift + y Close Task
Task Editing
- Alt + ⇧ Shift + s save task
looks ok… my main suggestion would be to create a new .m3u(8) instead of using the “current” playlist.
(going by memory here…)
shouldnt you do playlist_new() or_create() or whatever its called instead of remove_all_tracks()? also you arn’t stopping playback.. and thikning baout all that, all those “someetimes” make sense. depends on what playlist_remove_all_tracks(NULL) does it might very well leave you with a busted control file and/or resume info in global_status.
This one seems to actually work properly. It immediately starts playback, and exits the plugin (which seems like the safe thing to do, since starting playback will re-grab the audio buffer so what the plugin thinks is in there will bve wrong).
The new menu item is now also documented in the manual.
looks good
Small cleanups