Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10411 - Fixed point math code is bloated

Attached to Project: Rockbox
Opened by Jeffrey Goode (Blue_Dude) - Monday, 06 July 2009, 07:50 GMT+2
Last edited by Maurus Cuelenaere (mcuelenaere) - Tuesday, 07 July 2009, 15:36 GMT+2
Task Type Patches
Category Build environment
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Version 3.3
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

I originally rewrote some math code to use 64 bit internal variables, but after further investigation this proved unnecessary. This version restores 32 bit internal processing without risking overflow errors, and I cleaned up some unnecessary error checking. The bounds checking in replaygain is more than sufficient to prevent overflow errors in order to use these routines (it's actually quite conservative). This should result in slimmer builds.
   fixedpoint bloat.patch (7.7 KiB) 
 apps/fixedpoint.c |  129 ++++++++++++++++--------------------------------------
 1 file changed, 40 insertions(+), 89 deletions(-)

This task depends upon

Closed by  Maurus Cuelenaere (mcuelenaere)
Tuesday, 07 July 2009, 15:36 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  In r21701.

Loading...