Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10433 - Add Sun Audio codec

Attached to Project: Rockbox
Opened by Yoshihisa Uchida (Uchida) - Sunday, 12 July 2009, 14:16 GMT+1
Last edited by Yoshihisa Uchida (Uchida) - Sunday, 28 February 2010, 12:05 GMT+1
Task Type Patches
Category Codecs
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Add Sun Audio (.au/.snd) codec.

It is necessary to apply the patch of  FS#10422 ,  FS#10423 .
   rb_snd.patch (16.3 KiB) 
 b/apps/SOURCES                     |    1 
 b/apps/codecs/SOURCES              |    1 
 b/apps/codecs/codecs.make          |    1 
 b/apps/filetypes.c                 |    2 
 b/apps/metadata.c                  |   11 +
 b/apps/metadata.h                  |    1 
 b/apps/metadata/metadata_parsers.h |    1 
 b/apps/codecs/snd.c                |  297 +++++++++++++++++++++++++++++++++++++
 b/apps/metadata/snd.c              |  122 +++++++++++++++
 9 files changed, 437 insertions(+)

Closed by  Yoshihisa Uchida (Uchida)
Sunday, 28 February 2010, 12:05 GMT+1
Reason for closing:  Accepted
Additional comments about closing:  commit patch and manual updates.
Comment by alex wallis (alexwallis646) - Monday, 13 July 2009, 14:58 GMT+1
I can't get this patch to apply. all your other codec patches apply with no problem.
In this one though, all the files hunks fail.

Just a suggestion, but also if a lot of the tasks depend on each other, shouldn't this be made so they are shown as connected? as at the moment it only says they are in the task descriptions, they are not showing as depending on other tasks, where there is an option to show this in the fs entry.
Comment by Yoshihisa Uchida (Uchida) - Thursday, 16 July 2009, 16:50 GMT+1
In my build environment, all patches can be normally applied.

I operate the follwoing:
$ cd rockbox (~/rockbox is stored Rockbox souces)
$ patch -p1 < ../rb_aiff_wav.patch ( FS#10422 )
$ patch -p1 < ../rb_ieee_float.patch ( FS#10423 )
$ patch -p1 < ../rb_adpcms.patch ( FS#10424 )
$ patch -p1 < ../rb_ima_adpcms.patch ( FS#10425 )
$ patch -p1 < ../rb_snd.patch ( FS#10433 )

My build environment
OS
Linux
Windows + Cygwin

Source
r21903
Comment by Yoshihisa Uchida (Uchida) - Monday, 20 July 2009, 07:14 GMT+1
I send the patch which combined all patches ( FS#10422  -  FS#10425 , and  FS#10433 ).
   rb_snd_10422_10425.patch (138.9 KiB) 
 b/apps/SOURCES                             |    1 
 b/apps/codecs/SOURCES                      |    1 
 b/apps/codecs/aiff.c                       |  221 +++++----
 b/apps/codecs/codecs.make                  |    4 
 b/apps/codecs/wav.c                        |  654 ++++++-----------------------
 b/apps/filetypes.c                         |    2 
 b/apps/metadata.c                          |   11 
 b/apps/metadata.h                          |    1 
 b/apps/metadata/aiff.c                     |   23 -
 b/apps/metadata/metadata_parsers.h         |    1 
 b/apps/metadata/wave.c                     |  106 ++++
 b/apps/codecs/libpcms/SOURCES              |   10 
 b/apps/codecs/libpcms/dialogic_oki_adpcm.c |  138 ++++++
 b/apps/codecs/libpcms/dvi_adpcm.c          |  276 ++++++++++++
 b/apps/codecs/libpcms/ieee_float.c         |  147 ++++++
 b/apps/codecs/libpcms/ima_adpcm_common.c   |  169 +++++++
 b/apps/codecs/libpcms/ima_adpcm_common.h   |   32 +
 b/apps/codecs/libpcms/itut_g711.c          |  203 +++++++++
 b/apps/codecs/libpcms/libpcms.make         |   25 +
 b/apps/codecs/libpcms/linear_pcm.c         |  163 +++++++
 b/apps/codecs/libpcms/ms_adpcm.c           |  193 ++++++++
 b/apps/codecs/libpcms/pcm_common.h         |  125 +++++
 b/apps/codecs/libpcms/qt_ima_adpcm.c       |  118 +++++
 b/apps/codecs/libpcms/support_formats.h    |   55 ++
 b/apps/codecs/libpcms/swf_adpcm.c          |  198 ++++++++
 b/apps/codecs/libpcms/yamaha_adpcm.c       |  204 +++++++++
 b/apps/codecs/snd.c                        |  297 +++++++++++++
 b/apps/metadata/snd.c                      |  122 +++++
 28 files changed, 2872 insertions(+), 628 deletions(-)

Comment by Yoshihisa Uchida (Uchida) - Tuesday, 16 February 2010, 11:04 GMT+1
I send new patch.

changes
- sync r24691
- sync new  FS#10424 ,  FS#10425 , and  FS#10432  patch
- snd.c -> au.c

Please apply new  FS#10424 ,  FS#10425  and  FS#10432  patch before applying this patch.
   rb_au_codec_2.patch (17.1 KiB) 
 b/apps/SOURCES                     |    1 
 b/apps/codecs/SOURCES              |    1 
 b/apps/codecs/codecs.make          |    1 
 b/apps/filetypes.c                 |    2 
 b/apps/metadata.c                  |   11 +
 b/apps/metadata.h                  |    1 
 b/apps/metadata/metadata_parsers.h |    1 
 b/apps/codecs/au.c                 |  318 +++++++++++++++++++++++++++++++++++++
 b/apps/metadata/au.c               |  122 ++++++++++++++
 9 files changed, 458 insertions(+)

Loading...