Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10435 - page up/down doesn't work properly if title is displayed.

Attached to Project: Rockbox
Opened by Teruaki Kawashima (teru) - Monday, 13 July 2009, 16:29 GMT+2
Last edited by Teruaki Kawashima (teru) - Saturday, 01 August 2009, 17:00 GMT+2
Task Type Bugs
Category User Interface
Status Closed
Assigned To No-one
Player Type Gigabeat F/X
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

In gigabeat f/x, you can scroll page up/down by pressing A+ UP/DOWN in list such as browser or playlist viewer.
but scrolling page up/down skips extra one line.
for example, open playlist by "Context Menu" -> "Playlist" -> "Ceiw ".
items from 1 to 19 will be displayed and 1st item will be pointed.
then, press A+DOWN and 21st item will be pointed.
imo, 20th item should be pointed.
if you simply press A+DOWN again, 23rd item won't be shown.
the number would differ depending on lcd height and font.

this is because title is not taken account of when calcurating how many lines to skip.
here is a patch for this bug.
   gui_list_pgupdown_fix.patch (0.9 KiB) 
 apps/gui/list.c |   15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

This task depends upon

Closed by  Teruaki Kawashima (teru)
Saturday, 01 August 2009, 17:00 GMT+2
Reason for closing:  Fixed
Additional comments about closing:  Committed in r22082.
Comment by Dave Hooper (stripwax) - Thursday, 23 July 2009, 15:15 GMT+2
In my opinion, after page down the 19th item will be highlighted, rather than the 20th. Maybe that's just my preference?
Comment by Teruaki Kawashima (teru) - Wednesday, 29 July 2009, 17:23 GMT+2
Committed in r22082.

If i understand your comment correctly, attached patch would do what you want.
Maybe there can be a settings "overlap when page up/down"?
Anyway, i think it is nothing to do with the bug.
   list.diff (0.6 KiB) 
 apps/gui/list.c |    4 ++++
 1 file changed, 4 insertions(+)

Loading...