Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10447 - e200v2 lcd driver cleanup

Attached to Project: Rockbox
Opened by Michael Chicoine (mc2739) - Saturday, 18 July 2009, 06:45 GMT+2
Last edited by Bertrik Sikken (bertrik) - Saturday, 08 August 2009, 16:38 GMT+2
Task Type Patches
Category LCD
Status Closed
Assigned To No-one
Player Type Another
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch is for lcd-e200v2.c

It cleans up line lengths to be compliant with /trunk/docs/CONTRIBUTING
   line-length.patch (4 KiB) 
 firmware/target/arm/as3525/sansa-e200v2/lcd-e200v2.c |   41 ++++++++++++-------
 1 file changed, 26 insertions(+), 15 deletions(-)

This task depends upon

Closed by  Bertrik Sikken (bertrik)
Saturday, 08 August 2009, 16:38 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Committed as svn r22210
Comment by Bertrik Sikken (bertrik) - Saturday, 18 July 2009, 10:18 GMT+2
The backslashes at the end of a line are not needed for normal code, this is usually only required for multi-line #defines.
Also we could fix the spelling of the 'read' pixel at the end of the patch (to 'red' pixel I assume).
Comment by Michael Chicoine (mc2739) - Saturday, 18 July 2009, 14:54 GMT+2
Here is a new patch with those changes.
   line-length-v2.patch (4 KiB) 
 firmware/target/arm/as3525/sansa-e200v2/lcd-e200v2.c |   41 ++++++++++++-------
 1 file changed, 26 insertions(+), 15 deletions(-)

Loading...