Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10451 - backlight off on hold doesn't function properly

Attached to Project: Rockbox
Opened by Adriaan Leijnse (aidy) - Sunday, 19 July 2009, 19:35 GMT+2
Last edited by Thomas Martitz (kugel.) - Wednesday, 23 September 2009, 19:01 GMT+2
Task Type Bugs
Category Simulator
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

rev 21966

I don't know if this is intended behaviour or not, but when you enable 'backlight off on hold' in the simulator and enable hold mode, the screen only goes black once you press a key.
This task depends upon

Closed by  Thomas Martitz (kugel.)
Wednesday, 23 September 2009, 19:01 GMT+2
Reason for closing:  Fixed
Additional comments about closing:  Fixed in r22799.
Comment by Adriaan Leijnse (aidy) - Sunday, 19 July 2009, 21:33 GMT+2
It seems that it happens on the actual targets too, once you enable hold, nothing happens and the backlight goes off after the normal time-out instead of immediately.
Comment by Rob Purchase (shotofadds) - Wednesday, 22 July 2009, 22:14 GMT+2
This was originally reported on the Cowon D2, but aidy also reported that it happens in an X5 sim build. The problem is that "Normal" and "Off" settings both appear to wait for the same length of time before the backlight goes off.

The D2 and X5 both use BACKLIGHT_FADING_SW_HW_REG, if this is a clue.
Comment by Rob Purchase (shotofadds) - Thursday, 23 July 2009, 01:13 GMT+2
r22007 fixes the backlight-on-hold timeout issue on the D2, but does not change the behaviour of the sim.
Comment by Thomas Martitz (kugel.) - Monday, 14 September 2009, 19:28 GMT+2
That should fix it. It gets rid of the seperate button driver and uses what targets use also. Should've been done long ago :/
   0001-Rework-the-simulators-button-reading-to-not-... (13.5 KiB) 
 b/firmware/drivers/button.c    |   27 +++-
 b/uisimulator/sdl/button-sdl.h |   42 +++++++
 b/uisimulator/sdl/button.c     |  227 +++++------------------------------------
 3 files changed, 92 insertions(+), 204 deletions(-)

Loading...