Rockbox

Tasklist

FS#10453 - WPS bitmaps (backdrop) corrupted with recent build.

Attached to Project: Rockbox
Opened by PaulJam (PaulJam) - Monday, 20 July 2009, 09:44 GMT
Last edited by Jonathan Gordon (jdgordon) - Monday, 20 July 2009, 15:50 GMT
Task Type Bugs
Category Themes
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Using current build r21979 on a H300 (with default settings) i noticed some WPS corruption (see attached screendump).
This does not happen in the uisimulator.

With daily build r21977 this does not happen. So the recent cuesheet changes seem to cause this.
This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Monday, 20 July 2009, 15:50 GMT
Reason for closing:  Fixed
Additional comments about closing:  21982.
Comment by Akio Idehara (idak) - Monday, 20 July 2009, 12:04 GMT
I think r21978 is the cause.
Comment by Magnus Holmgren (learman) - Monday, 20 July 2009, 13:14 GMT
See it on my e200 too. Cuesheet support not enabled.
Comment by Magnus Holmgren (learman) - Monday, 20 July 2009, 13:29 GMT
I suspect the function audio_finish_load_track in playback.c to be the cause. It puts a temporary struct cuesheet on the stack. That the struct is close to 50 kB large, and since the audio thread stack is 5 kB, there ought to be a pretty big stack overflow. Kind of surprised it doesn't cause more problems. :)
Comment by Stefan Waldmann (Rockfan) - Monday, 20 July 2009, 14:26 GMT
The same thing here (Sansa e200).
Comment by Magnus Holmgren (learman) - Monday, 20 July 2009, 14:59 GMT
I disabled the bit of code with the struct cuesheet and that removed the WPS corruption.
Comment by Michael Chicoine (mc2739) - Monday, 20 July 2009, 15:16 GMT
There IS a stack overflow when cuesheet support is enabled and the current or next song has a cuesheet.
Comment by Jonathan Gordon (jdgordon) - Monday, 20 July 2009, 15:22 GMT
untested fix... try it out and commit if it works, or ill test after work today

Loading...