Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bugs
  • Category Codecs
  • Assigned To No-one
  • Operating System SW-codec
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by dreamlayers - 2009-07-31
Last edited by mortalis - 2013-11-18

FS#10477 - flac_seek may fail after 10 frame_sync attempts

With one particular FLAC/CUE combination, if I try to seek to track 2 in the CUE, I end up in the next file in the playlist. This happens because flac_sync fails to sync in 10 tries at one point. Then, flac_seek fails, flac_decode_frame fails, and the codec returns CODEC_ERROR.

I am attaching “frame_sync problem.flac”, which consists of two frames cut from the FLAC file. The file seek gets to what corresponds to offset 0x5F9, a place inside the first frame. The code ought to find the second frame, but it gives up after 10 tries in the “for(unparseable_count” loop. Increasing the limit to 20 (”unparseable_count < 20”) causes the seek to succeed, but that is probably a workaround, and not an ideal fix.

The same file also triggered  FS#10476 . However, I think that bug is not related.

I noticed the problem on my 5G iPod running r22076, and I performed debugging on the r22076 5G iPod sim.

Closed by  mortalis
2013-11-18 07:00
Reason for closing:  Fixed
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Commited as b770f63.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing