Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10496 - read_image close file?

Attached to Project: Rockbox
Opened by federico pelupessy (fip) - Saturday, 08 August 2009, 13:28 GMT+2
Last edited by Bertrik Sikken (bertrik) - Monday, 10 August 2009, 00:21 GMT+2
Task Type Bugs
Category Utils
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Version 3.3
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

I am not sure about whether it is actually used somewhere, but shouldn't
read_image_file_offset also close the file?
   read_image.patch (0.4 KiB) 
 plugins/lib/read_image.c |    1 +
 1 file changed, 1 insertion(+)

This task depends upon

Closed by  Bertrik Sikken (bertrik)
Monday, 10 August 2009, 00:21 GMT+2
Reason for closing:  Fixed
Additional comments about closing:  Function containing the bug has been removed in svn r22232, thanks for reporting.
Comment by Bertrik Sikken (bertrik) - Saturday, 08 August 2009, 17:15 GMT+2
I think your concern is valid, I can't see these files being closed anywhere.
Your patch will not work because the new code can not be reached.

The attached patch should fix that.
   read_image2.patch (1 KiB) 
 apps/plugins/lib/read_image.c |   12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

Comment by Bertrik Sikken (bertrik) - Saturday, 08 August 2009, 17:27 GMT+2
Hmm, on closer inspection, nobody seems to use that function so it's not causing any problems and we might just remove it altogether, see attached patch.
Maybe we should ask the original author first before removing.
   read_image3.patch (1.4 KiB) 
 apps/plugins/lib/read_image.c |   15 ---------------
 apps/plugins/lib/read_image.h |    3 ---
 2 files changed, 18 deletions(-)

Loading...