Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10497 - Mastermind on color LCDs

Attached to Project: Rockbox
Opened by Clément Pit--Claudel (CFP) - Saturday, 08 August 2009, 13:53 GMT+2
Last edited by Johannes Schwarz (Ubuntuxer) - Saturday, 24 October 2009, 21:00 GMT+2
Task Type Patches
Category Plugins
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Version 3.3
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Hello world :)

This plug-in adds a new game to rockbox, the mastermind game. It runs on all players with a color LCD, and I tested it on h10_5gb, iaudiox5, ipodnano, e200, ipodvideo (all sim), and gigabeat F (device).

I didn't find any bugs, but there must be some hiding here and there...

I've attached a screenshot.

CFP.

PS:
I've used PLA, although (if I remember well) it tends to be removed from plugins. What should I use then? #define(s) for each target? (the wiki page about plugins still advises to use PLA).
   Capture-Toshiba Gigabeat.png (22.1 KiB)
   mastermind.diff (14.6 KiB) 
 apps/plugins/CATEGORIES   |    1 
 apps/plugins/SOURCES      |    1 
 apps/plugins/mastermind.c |  466 ++++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 468 insertions(+)

This task depends upon

Closed by  Johannes Schwarz (Ubuntuxer)
Saturday, 24 October 2009, 21:00 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  r23332
Comment by Clément Pit--Claudel (CFP) - Saturday, 08 August 2009, 17:34 GMT+2
Rename the game to "codebuster" to avoid copyright issues.
   codebuster.diff (14.6 KiB) 
 apps/plugins/CATEGORIES   |    1 
 apps/plugins/SOURCES      |    1 
 apps/plugins/codebuster.c |  466 ++++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 468 insertions(+)

Comment by Rosso Maltese (asettico) - Tuesday, 11 August 2009, 08:07 GMT+2
Probably it could be possible to extend the game to the non-colour LCD targets using some patterns to show the different elements.
Furthermore it could be useful an option to choose colour/pattern mode, useful for colour-blind users.
Comment by Clément Pit--Claudel (CFP) - Wednesday, 12 August 2009, 17:46 GMT+2
* Add a color (original game: 8 colors and five pieces)
* Add an option to display frames
* Add an option to display numbers, a simple "patterns" mode. This allow to use the plugin on non-color LCDs, yet it is not enabled on these by default since it has not been tested yet.

CFP
   codebuster-v2.diff (15.7 KiB) 
 apps/plugins/CATEGORIES   |    1 
 apps/plugins/SOURCES      |    1 
 apps/plugins/codebuster.c |  497 ++++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 499 insertions(+)

Comment by Rosso Maltese (asettico) - Friday, 14 August 2009, 19:35 GMT+2
I got this warning in r22309.
/home/asettico-9.04/Sviluppo/rockbox/rockbox/apps/plugins/codebuster.c: In function ‘draw_piece’:
/home/asettico-9.04/Sviluppo/rockbox/rockbox/apps/plugins/codebuster.c:127: warning: ‘color’ may be used uninitialized in this function
Comment by Teruaki Kawashima (teru) - Sunday, 16 August 2009, 13:54 GMT+2
A few suggestions.
* Clear backdrop (i.e. rb->lcd_set_backdrop(NULL);) and set background color when you set foreground color.
It's not so playable with white background...
* It would be better to use *rb->current_tick for seed for rb->srand. IIUC, get_time returns always same value for non-RTC targets.
Comment by Clément Pit--Claudel (CFP) - Monday, 24 August 2009, 07:42 GMT+2
asettico: I couldn't reproduce this warning... I added an else statement anyway, tell me if it does any good.
teru: Done (I added an option to clear the backdrop).
   codebuster-v3.diff (15.7 KiB) 
 apps/plugins/CATEGORIES   |    1 
 apps/plugins/SOURCES      |    1 
 apps/plugins/codebuster.c |  501 ++++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 503 insertions(+)

Comment by Clément Pit--Claudel (CFP) - Monday, 24 August 2009, 09:50 GMT+2
Woops, remove tabs.
   codebuster-v4.diff (15.2 KiB) 
 apps/plugins/codebuster.c |  501 ++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 501 insertions(+)

Comment by Clément Pit--Claudel (CFP) - Monday, 24 August 2009, 09:52 GMT+2
... Add missing files
   codebuster-v5.diff (15.8 KiB) 
 apps/plugins/codebuster.c |  501 ++++++++++++++++++++++++++++++++++++++++++++++
 apps/plugins/SOURCES      |    1 
 apps/plugins/CATEGORIES   |    1 
 3 files changed, 503 insertions(+)

Comment by Mustapha Senhaji (DrMoos) - Tuesday, 15 September 2009, 18:22 GMT+2
I will try to look at it this week.
Comment by Rosso Maltese (asettico) - Wednesday, 16 September 2009, 11:22 GMT+2
OK, I got any error both for the sim and the FW. Thank you! :-)
Comment by Rosso Maltese (asettico) - Saturday, 17 October 2009, 10:36 GMT+2
Sync to 23221.
   plugins-10497codebuster-v5.0.patch (15.8 KiB) 
 apps/plugins/codebuster.c |  501 ++++++++++++++++++++++++++++++++++++++++++++++
 apps/plugins/CATEGORIES   |    1 
 apps/plugins/SOURCES      |    1 
 3 files changed, 503 insertions(+)

Comment by Johannes Schwarz (Ubuntuxer) - Sunday, 18 October 2009, 13:30 GMT+2
A few suggestions:
- delete the option clear backdrop instead use a background image or just let the background black
- the option display frames doesn't work; I would delete it
- use just one menu
- add a standard rockbox header label

Before the new game can be committed, it needs essentially a manual. In my opinion it doesn't need urgently a non-coloured target support.
Comment by Johannes Schwarz (Ubuntuxer) - Monday, 19 October 2009, 00:26 GMT+2
I implemented the suggestions above.
   codebuster-v6.diff (15.5 KiB) 
 apps/plugins/CATEGORIES   |    1 
 apps/plugins/SOURCES      |    1 
 apps/plugins/codebuster.c |  468 ++++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 470 insertions(+)

Comment by Clément Pit--Claudel (CFP) - Tuesday, 20 October 2009, 23:01 GMT+2
Great! I haven't had any time to work on this lately, but I'll write the manual section during the holidays, so that it can be commited.
CFP.
Comment by Johannes Schwarz (Ubuntuxer) - Wednesday, 21 October 2009, 17:35 GMT+2
Ok, I fixed some bugs and revised the menu, so I think it's easy of use and the settings are saved now. Besides I made the game usable on small display sizes (c200).
I wrote that display frames doesn't wrote, but this isn't right and I reinserted it.
Please have a look at my changes. After you write the manual section, I'll commit your game.
   codebuster-v7.diff (17.1 KiB) 
 apps/plugins/CATEGORIES   |    1 
 apps/plugins/SOURCES      |    1 
 apps/plugins/codebuster.c |  514 ++++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 516 insertions(+)

Comment by Clément Pit--Claudel (CFP) - Saturday, 24 October 2009, 11:30 GMT+2
First of all, I like the changes you made ; thanks a lot !

I started writing the manual ; could you take a look at the diff to see if I forgot targets, or made any mistakes ? Do not hesitate to rephrase some of the sentences, I fear that my English still needs to improve..

Somehow, I liked to have the menu button enabled on gigabeat: it feels strange that in plugins, the POWER button goes to the menus, while in other screens the MENU key is used, and power exits... Plus, in some plugins, the POWER key does exit the plugin, which always makes me wonder whether I'm going to exit the game when trying to get to a game's menu. What about re-enabling the menu button, at least for Gigabeat ?

I didn't know how to add binary files to a patch, so I'm attaching images for the manual separatly.

CFP.

PS: I just came into a problem: it seems that on the new version, on targets with a scrollwheel, when you try to change the color a piece, it moves by two colors at once, and I can't really figure out why...
   codebuster-v8.diff (21.2 KiB) 
 apps/plugins/CATEGORIES       |    1 
 apps/plugins/SOURCES          |    1 
 apps/plugins/codebuster.c     |  514 ++++++++++++++++++++++++++++++++++++++++++
 manual/plugins/codebuster.tex |   32 ++
 manual/plugins/main.tex       |    2 
 5 files changed, 550 insertions(+)

   ss-codebuster-160x128x16.png (0.6 KiB)
   ss-codebuster-176x132x16.png (0.6 KiB)
   ss-codebuster-176x220x16.png (0.8 KiB)
   ss-codebuster-220x176x16.png (0.7 KiB)
   ss-codebuster-240x320x16.png (0.9 KiB)
Comment by Teruaki Kawashima (teru) - Saturday, 24 October 2009, 13:15 GMT+2
In my thought, in the game plugin on gigabeat, POWER is not a key to bring up the menu, is a key to exit game and go back to the menu. so there isn't wonder for me.

I'd suggest to rename colorblind to labeling or something like.
I'm confused by button mapping. UP usually increases number and DOWN usually decreases number. it is confusing for me that it is contrary in your game.
Comment by Johannes Schwarz (Ubuntuxer) - Saturday, 24 October 2009, 20:36 GMT+2
> PS: I just came into a problem: it seems that on the new version, on targets with a scrollwheel, when you try to change the color a piece, it moves by two colors at once, and I can't really figure out why...
I suppose it's a bug in the simulator or the pluginlib_action, because on my Sansa e200 the problem doesn't occure.
>I'd suggest to rename colorblind to labeling or something like.
yes, colorblind is really unsuitable
>I'm confused by button mapping. UP usually increases number and DOWN usually decreases number. it is confusing for me that it is contrary in your game.
You're right, but the problem occurs because of the bad pluginlib_action. If you scroll down the number is increased rightly. kugel is working on it.  FS#10387 

Loading...